You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/03/18 19:33:58 UTC

[kudu-CR] run-test: squelch popd output

Hello Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/6426

to review the following change.

Change subject: run-test: squelch popd output
......................................................................

run-test: squelch popd output

This change turns this:

$ ../../build-support/run-test.sh bin/kudu-tool-test --gtest_filter=*Check*
Running kudu-tool-test, redirecting output ...
~/Source/kudu/build/debug
$

Into this:

$ ../../build-support/run-test.sh bin/kudu-tool-test --gtest_filter=*Check*
Running kudu-tool-test, redirecting output ...
$

Change-Id: I1ef1fbc32f77505b05d16d6192741b1260a72663
---
M build-support/run-test.sh
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/6426/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ef1fbc32f77505b05d16d6192741b1260a72663
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] run-test: squelch popd output

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.

Change subject: run-test: squelch popd output
......................................................................


run-test: squelch popd output

This change turns this:

$ ../../build-support/run-test.sh bin/kudu-tool-test --gtest_filter=*Check*
Running kudu-tool-test, redirecting output ...
~/Source/kudu/build/debug
$

Into this:

$ ../../build-support/run-test.sh bin/kudu-tool-test --gtest_filter=*Check*
Running kudu-tool-test, redirecting output ...
$

Change-Id: I1ef1fbc32f77505b05d16d6192741b1260a72663
Reviewed-on: http://gerrit.cloudera.org:8080/6426
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M build-support/run-test.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1ef1fbc32f77505b05d16d6192741b1260a72663
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] run-test: squelch popd output

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: run-test: squelch popd output
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ef1fbc32f77505b05d16d6192741b1260a72663
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No