You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/10 18:50:13 UTC

[GitHub] [pulsar] michaeljmarshall opened a new pull request #12008: Remove unnecessary creation of JsonParser object per deprecation doc

michaeljmarshall opened a new pull request #12008:
URL: https://github.com/apache/pulsar/pull/12008


   ### Motivation
   
   The modified `JsonParser` is deprecated. The library includes java docs (copied below) indicating how to fix. This PR follows those instructions. As a result, we will use the static method and prevent the creation of the `JsonParser` object.
   
   ```java
     /** @deprecated No need to instantiate this class, use the static methods instead. */
     @Deprecated
     public JsonParser() {}
   ```
   
   ```java
     /** @deprecated Use {@link JsonParser#parseString} */
     @Deprecated
     public JsonElement parse(String json) throws JsonSyntaxException {
       return parseString(json);
     }
   ```
   
   ### Modifications
   
   * Use static method instead of creating a `JsonParser` object.
   
   ### Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
   No.
   
   ### Documentation
   
   No doc updates needed.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on pull request #12008: Remove unnecessary creation of JsonParser object per deprecation doc

Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #12008:
URL: https://github.com/apache/pulsar/pull/12008#issuecomment-917224753


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari merged pull request #12008: Remove unnecessary creation of JsonParser object per deprecation doc

Posted by GitBox <gi...@apache.org>.
lhotari merged pull request #12008:
URL: https://github.com/apache/pulsar/pull/12008


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on pull request #12008: Remove unnecessary creation of JsonParser object per deprecation doc

Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #12008:
URL: https://github.com/apache/pulsar/pull/12008#issuecomment-917246862


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on pull request #12008: Remove unnecessary creation of JsonParser object per deprecation doc

Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #12008:
URL: https://github.com/apache/pulsar/pull/12008#issuecomment-917209496


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org