[GitHub] matthiasblaesing commented on issue #940: [NETBEANS-1074] Module Review web.struts

[GitBox <gi...@apache.org>]

matthiasblaesing commented on issue #940: [NETBEANS-1074] Module Review web.struts
URL: https://github.com/apache/incubator-netbeans/pull/940#issuecomment-429253170
 
 
   I see a few problems - I pushed an updated branch here:
   
   https://github.com/matthiasblaesing/incubator-netbeans/tree/github-pr-940
   
   - Use the declarative method for copying files and let the build system do the work
   https://github.com/matthiasblaesing/incubator-netbeans/commit/aadd5122b4ceac942ef9e5eba1fb1bc6a1d1f82c
   - Include DTD/XML/TLD files with correct license attribution 
   https://github.com/matthiasblaesing/incubator-netbeans/commit/463af8c90453e028a12e214d03333024d5249555
   If you just extract the DTD/XML/TLD files, you won't get the license information. From the perspective of the build system the external dependency is not used and as such the license/notice is not included. My change moves the license information into the `licenseninfo.xml` file where it can be extracted from. 
   - The referenced libraries are almost all Apache libraries and normally they come with NOTICE files, which we are required to analyse and if appropriate include in our NOTICE file. Just adding the `NOTICE.txt` in `external` does not work, as the build system won't promote the file into build binaries. The build system was enhanced to pick up a `<basename>-notice.txt` file, if it would pick up a `<basename>-license.txt` file and include the contents of that file into the final netbeans NOTICE file. I removed the javadoc license files and replaced them with a `Files` header in the main artifact license file. For `antlr` the license is not correct. ANTLR _2_ is public domain and a matching license file is already present in the `nbbuild/licenses` directory. These changes are committed as: https://github.com/matthiasblaesing/incubator-netbeans/commit/81878a431221da0f801dccca9f2bda797539dddb
   - The struts javadoc does not need to be rebuild everytime `build-init` is called. It was be conditionalized and moved to embedded `zipfileset`s instead of expanding the zip and rezipping them: https://github.com/matthiasblaesing/incubator-netbeans/commit/3daed9b79b2fc7810c9744af743501079a77550f
   
   In the second commit above I also rebuild `struts-config_1_3-custom.dtd`. It is trivially derived from `struts-config_1_3.dtd`, the process is described in the document itself. This also fixed a build failure, as without `struts-config_1_3-custom.dtd` the build just does not work. The license for that file than results from the original file.
   
   The `web-app_2_3.dtd` is not referenced and thus removed from the codebase.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists