[GitHub] [netbeans] jglick commented on a change in pull request #1144: [NETBEANS-2284]:NB build with jdk11

[GitBox <gi...@apache.org>]

jglick commented on a change in pull request #1144: [NETBEANS-2284]:NB build with jdk11
URL: https://github.com/apache/netbeans/pull/1144#discussion_r290356421
 
 

 ##########
 File path: java/maven/build.xml
 ##########
 @@ -30,8 +30,8 @@
         <javac srcdir="mavensrc" destdir="build/mavenclasses" 
             debug="${build.compiler.debug}" 
             deprecation="${build.compiler.deprecation}" 
-            source="1.5" 
-            target="1.5" 
+            source="${javac.source}" 
+            target="${javac.target}" 
 
 Review comment:
   Introduced [NETBEANS-2639](https://issues.apache.org/jira/browse/NETBEANS-2639). More broadly, I suspect a lot of source/target level patches here are incorrect.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists