[GitHub] renato2099 commented on issue #75: Add startsWith predicate

[GitBox <gi...@apache.org>]

renato2099 commented on issue #75: Add startsWith predicate 
URL: https://github.com/apache/incubator-iceberg/pull/75#issuecomment-453873882
 
 
   Thanks for the feedback @rdblue! 
   I see what you mean, I wasn't aware of this. I have a few questions about it though:
   - So regarding the transform for `startsWith` should it go in its own class com.netflix.iceberg.transforms.StartsWith? or should it just go into com.netflix.iceberg.transforms.Transforms? I know it will go for sure into com.netflix.iceberg.expressions.Projections as well
   - When using this `startsWith(part0, 'aaaa')`, does it also mean adding a PartitionSpec method?
   - I guess that when using `startsWith(part0, 'aaaa')`, we would only have at most two partitions, where is this taken into account? I guess this is used on the read and write path, could you point me to that part of the code?
   - A clarification question. What do you mean by: " a projection is the predicate converted to work on partition values."? 
   Thanks in advanced!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org