You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/02/16 12:52:27 UTC

[GitHub] [maven-plugin-testing] SingingBush opened a new pull request #10: Add Github Workflows CI for JDK 7 - 13

SingingBush opened a new pull request #10: Add Github Workflows CI for JDK 7 - 13
URL: https://github.com/apache/maven-plugin-testing/pull/10
 
 
   Although the project already has Jenkins for CI it would be really helpful to use the in built Github Actions CI for quick builds and visibility for contributors that don't have visibility of the Jenkins builds.
   
   The workflow in this PR builds with multiple Java versions (7 to 13) and completes in about 3 mins.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-plugin-testing] SingingBush commented on a change in pull request #10: Add Github Workflows CI for JDK 7 - 13

Posted by GitBox <gi...@apache.org>.
SingingBush commented on a change in pull request #10: Add Github Workflows CI for JDK 7 - 13
URL: https://github.com/apache/maven-plugin-testing/pull/10#discussion_r379903422
 
 

 ##########
 File path: .github/workflows/maven.yml
 ##########
 @@ -0,0 +1,43 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Java CI
+
+on: [push]
+
+jobs:
+  build:
+    name: Test with Java ${{ matrix.jdk }}
+    #runs-on: ${{ matrix.os }}
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        jdk: [1.7, 1.8, 9, 10, 11, 12, 13]
 
 Review comment:
   It doesn't add much overhead but I'll remove them

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-plugin-testing] SingingBush commented on a change in pull request #10: Add Github Workflows CI for JDK 7 - 13

Posted by GitBox <gi...@apache.org>.
SingingBush commented on a change in pull request #10: Add Github Workflows CI for JDK 7 - 13
URL: https://github.com/apache/maven-plugin-testing/pull/10#discussion_r379903447
 
 

 ##########
 File path: .github/workflows/maven.yml
 ##########
 @@ -0,0 +1,43 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Java CI
+
+on: [push]
+
+jobs:
+  build:
+    name: Test with Java ${{ matrix.jdk }}
+    #runs-on: ${{ matrix.os }}
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        jdk: [1.7, 1.8, 9, 10, 11, 12, 13]
+        #os: [ubuntu-latest, windows-latest, macOS-latest]
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up JDK ${{ matrix.jdk }}
+      uses: actions/setup-java@v1
+      with:
+        java-version: ${{ matrix.jdk }}
+    - name: Build with Maven
+      run: mvn -B package --file pom.xml
 
 Review comment:
   that's fair enough. Will push again

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-plugin-testing] michael-o commented on a change in pull request #10: Add Github Workflows CI for JDK 7 - 13

Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #10: Add Github Workflows CI for JDK 7 - 13
URL: https://github.com/apache/maven-plugin-testing/pull/10#discussion_r379901473
 
 

 ##########
 File path: .github/workflows/maven.yml
 ##########
 @@ -0,0 +1,43 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Java CI
+
+on: [push]
+
+jobs:
+  build:
+    name: Test with Java ${{ matrix.jdk }}
+    #runs-on: ${{ matrix.os }}
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        jdk: [1.7, 1.8, 9, 10, 11, 12, 13]
 
 Review comment:
   Testing 9, 10 and 12 is a waste of time. They are dead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-plugin-testing] michael-o commented on a change in pull request #10: Add Github Workflows CI for JDK 7 - 13

Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #10: Add Github Workflows CI for JDK 7 - 13
URL: https://github.com/apache/maven-plugin-testing/pull/10#discussion_r379901519
 
 

 ##########
 File path: .github/workflows/maven.yml
 ##########
 @@ -0,0 +1,43 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Java CI
+
+on: [push]
+
+jobs:
+  build:
+    name: Test with Java ${{ matrix.jdk }}
+    #runs-on: ${{ matrix.os }}
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        jdk: [1.7, 1.8, 9, 10, 11, 12, 13]
+        #os: [ubuntu-latest, windows-latest, macOS-latest]
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up JDK ${{ matrix.jdk }}
+      uses: actions/setup-java@v1
+      with:
+        java-version: ${{ matrix.jdk }}
+    - name: Build with Maven
+      run: mvn -B package --file pom.xml
 
 Review comment:
   `clean verify` is the command to run...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services