You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2019/03/14 00:13:16 UTC
[Impala-ASF-CR] IMPALA-8305: Generate JUnitXML for DCHECK failures
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12751
Change subject: IMPALA-8305: Generate JUnitXML for DCHECK failures
......................................................................
IMPALA-8305: Generate JUnitXML for DCHECK failures
DCHECKs log at the FATAL level and produce a statement starting
with "Check failed:". This generates a JUnitXML when it sees a
FATAL log file with "Check failed:". Some backend death tests
specifically test hitting certain DCHECKs, so the be_tests
directory is ignored.
Something that hits a DCHECK would also generate a minidump,
so this is just additional information beyond the existing
JUnitXML for the minidump.
Testing:
- Tested on logs from a test that hit a DCHECK in impalad
- Ran a normal error-free run
Change-Id: Ic45d01b6a87b1d81967f1e10028af96a7cc3071a
---
M bin/jenkins/finalize.sh
1 file changed, 15 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/12751/1
--
To view, visit http://gerrit.cloudera.org:8080/12751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic45d01b6a87b1d81967f1e10028af96a7cc3071a
Gerrit-Change-Number: 12751
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-8305: Generate JUnitXML for DCHECK failures
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12751 )
Change subject: IMPALA-8305: Generate JUnitXML for DCHECK failures
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic45d01b6a87b1d81967f1e10028af96a7cc3071a
Gerrit-Change-Number: 12751
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 16 Mar 2019 02:57:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8305: Generate JUnitXML for DCHECK failures
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12751 )
Change subject: IMPALA-8305: Generate JUnitXML for DCHECK failures
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2430/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic45d01b6a87b1d81967f1e10028af96a7cc3071a
Gerrit-Change-Number: 12751
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Mar 2019 00:54:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8305: Generate JUnitXML for DCHECK failures
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12751
to look at the new patch set (#2).
Change subject: IMPALA-8305: Generate JUnitXML for DCHECK failures
......................................................................
IMPALA-8305: Generate JUnitXML for DCHECK failures
DCHECKs log at the FATAL level and produce a statement starting
with "Check failed:". This generates a JUnitXML when it sees a
FATAL log file with "Check failed:". Some backend death tests
specifically test hitting certain DCHECKs, so the be_tests
directory is ignored.
Something that hits a DCHECK would also generate a minidump,
so this is just additional information beyond the existing
JUnitXML for the minidump.
Testing:
- Tested on logs from a test that hit a DCHECK in impalad
- Ran a normal error-free run
Change-Id: Ic45d01b6a87b1d81967f1e10028af96a7cc3071a
---
M bin/jenkins/finalize.sh
1 file changed, 15 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/12751/2
--
To view, visit http://gerrit.cloudera.org:8080/12751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic45d01b6a87b1d81967f1e10028af96a7cc3071a
Gerrit-Change-Number: 12751
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8305: Generate JUnitXML for DCHECK failures
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12751 )
Change subject: IMPALA-8305: Generate JUnitXML for DCHECK failures
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2437/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic45d01b6a87b1d81967f1e10028af96a7cc3071a
Gerrit-Change-Number: 12751
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Mar 2019 23:59:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8305: Generate JUnitXML for DCHECK failures
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/12751 )
Change subject: IMPALA-8305: Generate JUnitXML for DCHECK failures
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic45d01b6a87b1d81967f1e10028af96a7cc3071a
Gerrit-Change-Number: 12751
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Mar 2019 21:49:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8305: Generate JUnitXML for DCHECK failures
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12751 )
Change subject: IMPALA-8305: Generate JUnitXML for DCHECK failures
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3917/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/12751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic45d01b6a87b1d81967f1e10028af96a7cc3071a
Gerrit-Change-Number: 12751
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Mar 2019 22:39:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8305: Generate JUnitXML for DCHECK failures
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12751 )
Change subject: IMPALA-8305: Generate JUnitXML for DCHECK failures
......................................................................
IMPALA-8305: Generate JUnitXML for DCHECK failures
DCHECKs log at the FATAL level and produce a statement starting
with "Check failed:". This generates a JUnitXML when it sees a
FATAL log file with "Check failed:". Some backend death tests
specifically test hitting certain DCHECKs, so the be_tests
directory is ignored.
Something that hits a DCHECK would also generate a minidump,
so this is just additional information beyond the existing
JUnitXML for the minidump.
Testing:
- Tested on logs from a test that hit a DCHECK in impalad
- Ran a normal error-free run
Change-Id: Ic45d01b6a87b1d81967f1e10028af96a7cc3071a
Reviewed-on: http://gerrit.cloudera.org:8080/12751
Reviewed-by: David Knupp <dk...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/jenkins/finalize.sh
1 file changed, 15 insertions(+), 0 deletions(-)
Approvals:
David Knupp: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic45d01b6a87b1d81967f1e10028af96a7cc3071a
Gerrit-Change-Number: 12751
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>