You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2017/01/17 23:57:09 UTC

Review Request 55654: Renamed `CONFIGURE_FLAGS` to `CMAKE_ARGS`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55654/
-----------------------------------------------------------

Review request for mesos and Benjamin Bannier.


Repository: mesos


Description
-------

Updated `support/mesos-tidy/README.md` accordingly + minor updates.


Diffs
-----

  support/mesos-tidy.sh 96d3ecb91f5476ff499ca5f043c527681c30efe9 
  support/mesos-tidy/README.md e285632c53613d67a5317bbc8c443fe2d06ba38a 
  support/mesos-tidy/entrypoint.sh c1de19999c6ea8622fb7b4a7aa313af8d46ed256 

Diff: https://reviews.apache.org/r/55654/diff/


Testing
-------


Thanks,

Michael Park

Re: Review Request 55654: Renamed `CONFIGURE_FLAGS` to `CMAKE_ARGS`.

Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55654/#review162071
-----------------------------------------------------------


Fix it, then Ship it!





support/mesos-tidy/README.md (line 8)
<https://reviews.apache.org/r/55654/#comment233318>

    Not yours, but would you mind changing this to `This directory is intended for ...`?



support/mesos-tidy/README.md (line 48)
<https://reviews.apache.org/r/55654/#comment233339>

    nit: Could you add an extra newline?


- Benjamin Bannier


On Jan. 18, 2017, 9:58 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55654/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2017, 9:58 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated `support/mesos-tidy/README.md` accordingly + minor updates.
> 
> 
> Diffs
> -----
> 
>   support/mesos-tidy.sh 96d3ecb91f5476ff499ca5f043c527681c30efe9 
>   support/mesos-tidy/README.md e285632c53613d67a5317bbc8c443fe2d06ba38a 
>   support/mesos-tidy/entrypoint.sh c1de19999c6ea8622fb7b4a7aa313af8d46ed256 
> 
> Diff: https://reviews.apache.org/r/55654/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 55654: Renamed `CONFIGURE_FLAGS` to `CMAKE_ARGS`.

Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55654/
-----------------------------------------------------------

(Updated Jan. 18, 2017, 6:54 a.m.)


Review request for mesos and Benjamin Bannier.


Changes
-------

Addressed Benjamin's comments.


Repository: mesos


Description (updated)
-------

Updated `support/mesos-tidy/README.md` accordingly + minor updates.


Diffs (updated)
-----

  support/mesos-tidy.sh 96d3ecb91f5476ff499ca5f043c527681c30efe9 
  support/mesos-tidy/README.md e285632c53613d67a5317bbc8c443fe2d06ba38a 
  support/mesos-tidy/entrypoint.sh c1de19999c6ea8622fb7b4a7aa313af8d46ed256 

Diff: https://reviews.apache.org/r/55654/diff/


Testing
-------


Thanks,

Michael Park

Re: Review Request 55654: Renamed `CONFIGURE_FLAGS` to `CMAKE_ARGS`.

Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55654/
-----------------------------------------------------------

(Updated Jan. 18, 2017, 12:58 a.m.)


Review request for mesos and Benjamin Bannier.


Repository: mesos


Description (updated)
-------

Updated `support/mesos-tidy/README.md` accordingly + minor updates.


Diffs (updated)
-----

  support/mesos-tidy.sh 96d3ecb91f5476ff499ca5f043c527681c30efe9 
  support/mesos-tidy/README.md e285632c53613d67a5317bbc8c443fe2d06ba38a 
  support/mesos-tidy/entrypoint.sh c1de19999c6ea8622fb7b4a7aa313af8d46ed256 

Diff: https://reviews.apache.org/r/55654/diff/


Testing
-------


Thanks,

Michael Park

Re: Review Request 55654: Renamed `CONFIGURE_FLAGS` to `CMAKE_ARGS`.

Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55654/
-----------------------------------------------------------

(Updated Jan. 17, 2017, 6:35 p.m.)


Review request for mesos and Benjamin Bannier.


Changes
-------

Rebased.


Repository: mesos


Description
-------

Updated `support/mesos-tidy/README.md` accordingly + minor updates.


Diffs (updated)
-----

  support/mesos-tidy.sh 96d3ecb91f5476ff499ca5f043c527681c30efe9 
  support/mesos-tidy/README.md e285632c53613d67a5317bbc8c443fe2d06ba38a 
  support/mesos-tidy/entrypoint.sh c1de19999c6ea8622fb7b4a7aa313af8d46ed256 

Diff: https://reviews.apache.org/r/55654/diff/


Testing
-------


Thanks,

Michael Park