[GitHub] [james-project] Arsnael commented on pull request #423: JAMES-XXXX Handle JMAP WebSocket ping

[GitBox <gi...@apache.org>]

Arsnael commented on pull request #423:
URL: https://github.com/apache/james-project/pull/423#issuecomment-857603692


   I have been thinking again... Do we need at all this PR? It feels like reactor netty is managing that out of the box somehow, if you send it a ping, it answers a pong... And when I tested with websocat, I had that issue of having a closing connection. But when I added the ping option I think it was not closing anymore... 
   
   I will check again tomorrow but I think it works that way... Regarding Gatling though, could not find a way to send a ping... But Didn't have much time to look, will dig more tomorrow.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org