You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/23 12:28:50 UTC

[GitHub] [pulsar-client-go] faceair commented on issue #352: Use dependency injection for metrics

faceair commented on issue #352:
URL: https://github.com/apache/pulsar-client-go/issues/352#issuecomment-697331210


   I'd prefer to add a method that returns only internal statistics, and not bind to prometheus. More generic SDKs are used in this way, e.g. https://golang.org/pkg/database/sql/#DB.Stats, https://github.com/go-redis/redis/blob/v8.2.0/redis.go#L618
   
   We're still using graphite, and maybe someone else is using some other metrics system.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org