[GitHub] [cassandra] yifan-c edited a comment on pull request #883: CASSANDRA-16398: add ACCESS and DATACENTERS to unreserved keywords

[GitBox <gi...@apache.org>]

yifan-c edited a comment on pull request #883:
URL: https://github.com/apache/cassandra/pull/883#issuecomment-770021253


   @blerer thanks for the feedback. 
   I move the test to `CreateTest` and rewrite using `createTable()` instead of invoking cqlsh. 
   
   I also made an optional commit c81be6f that determines all the unreserved keywords and enumerate through to give the best coverage. It helps to prevent the scenario that adds a keyword but forgot to add it to either unreserved or reserved list. 
   However, the commit opens up the access level to `ReservedKeywords` class. Would it be a concern? Intuitively, I think "no". Or if we want to keep the access level, we can move the test into `ReservedKeywordsTest` (and potentially change the test class name)?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org