You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/02/17 20:04:59 UTC
[GitHub] [gobblin] autumnust opened a new pull request #3228: [GOBBLIN-1389] Ensuring exception being propagated in Hive-Reg code path
autumnust opened a new pull request #3228:
URL: https://github.com/apache/gobblin/pull/3228
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
https://issues.apache.org/jira/browse/GOBBLIN-1389
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
This small PR just ensures the exception occurred while hive-registration will be propagated as it is so that users/developers would be able to learn the root cause easily.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] aplex commented on a change in pull request #3228: [GOBBLIN-1389] Ensuring exception being propagated in Hive-Reg code path
Posted by GitBox <gi...@apache.org>.
aplex commented on a change in pull request #3228:
URL: https://github.com/apache/gobblin/pull/3228#discussion_r577918774
##########
File path: gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreBasedRegister.java
##########
@@ -377,7 +378,7 @@ public Boolean call() throws Exception {
}
});
} catch (ExecutionException ee) {
- throw new IOException("Database existence checking throwing execution exception.");
+ throw new IOException("Database existence checking throwing execution exception.", ee);
Review comment:
Do we know the typical reasons for the exception at this place, or it's hard to tell at this layer?
Ideally, exception messages should be in the format of "Problem happened because of A, do B to resolve it".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] autumnust commented on a change in pull request #3228: [GOBBLIN-1389] Ensuring exception being propagated in Hive-Reg code path
Posted by GitBox <gi...@apache.org>.
autumnust commented on a change in pull request #3228:
URL: https://github.com/apache/gobblin/pull/3228#discussion_r577981910
##########
File path: gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreBasedRegister.java
##########
@@ -377,7 +378,7 @@ public Boolean call() throws Exception {
}
});
} catch (ExecutionException ee) {
- throw new IOException("Database existence checking throwing execution exception.");
+ throw new IOException("Database existence checking throwing execution exception.", ee);
Review comment:
It is hard to tell here. Mostly likely it could be Hive related issue, but maybe too vague to give users useful instructions to fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] asfgit closed pull request #3228: [GOBBLIN-1389] Ensuring exception being propagated in Hive-Reg code path
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3228:
URL: https://github.com/apache/gobblin/pull/3228
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org