You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@taverna.apache.org by ia...@apache.org on 2016/10/05 16:02:08 UTC
[1/2] incubator-taverna-mobile git commit: fix: crash on click more
progressbar in workflow and NPE handled
Repository: incubator-taverna-mobile
Updated Branches:
refs/heads/master b91d8a633 -> 3ca65e888
fix: crash on click more progressbar in workflow and NPE handled
Project: http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/commit/1b1ad62a
Tree: http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/tree/1b1ad62a
Diff: http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/diff/1b1ad62a
Branch: refs/heads/master
Commit: 1b1ad62a5faffd2a82ca0aba6d404af740beb998
Parents: c8e4b19
Author: Rajan Maurya <ra...@gmail.com>
Authored: Wed Oct 5 17:45:41 2016 +0530
Committer: Rajan Maurya <ra...@gmail.com>
Committed: Wed Oct 5 17:45:41 2016 +0530
----------------------------------------------------------------------
.../taverna/mobile/ui/workflow/WorkflowFragment.java | 10 ++++++----
app/src/main/res/layout/item_progressbar.xml | 2 +-
2 files changed, 7 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/blob/1b1ad62a/app/src/main/java/org/apache/taverna/mobile/ui/workflow/WorkflowFragment.java
----------------------------------------------------------------------
diff --git a/app/src/main/java/org/apache/taverna/mobile/ui/workflow/WorkflowFragment.java b/app/src/main/java/org/apache/taverna/mobile/ui/workflow/WorkflowFragment.java
index 6d27d99..44033f4 100644
--- a/app/src/main/java/org/apache/taverna/mobile/ui/workflow/WorkflowFragment.java
+++ b/app/src/main/java/org/apache/taverna/mobile/ui/workflow/WorkflowFragment.java
@@ -208,10 +208,12 @@ public class WorkflowFragment extends Fragment implements WorkflowMvpView,
@Override
public void onItemClick(View childView, int position) {
- Intent intent = new Intent(getActivity(), WorkflowDetailActivity.class);
- intent.putExtra("id", mWorkflowList.get(position).getId());
- intent.putExtra("title", mWorkflowList.get(position).getTitle());
- startActivity(intent);
+ if (mWorkflowList.get(position) != null && position != -1) {
+ Intent intent = new Intent(getActivity(), WorkflowDetailActivity.class);
+ intent.putExtra("id", mWorkflowList.get(position).getId());
+ intent.putExtra("title", mWorkflowList.get(position).getTitle());
+ startActivity(intent);
+ }
}
@Override
http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/blob/1b1ad62a/app/src/main/res/layout/item_progressbar.xml
----------------------------------------------------------------------
diff --git a/app/src/main/res/layout/item_progressbar.xml b/app/src/main/res/layout/item_progressbar.xml
index 8498971..6634510 100644
--- a/app/src/main/res/layout/item_progressbar.xml
+++ b/app/src/main/res/layout/item_progressbar.xml
@@ -17,7 +17,7 @@
-->
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
- android:layout_height="match_parent"
+ android:layout_height="wrap_content"
android:orientation="vertical" >
<ProgressBar
[2/2] incubator-taverna-mobile git commit: This closes #30
Posted by ia...@apache.org.
This closes #30
Project: http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/commit/3ca65e88
Tree: http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/tree/3ca65e88
Diff: http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/diff/3ca65e88
Branch: refs/heads/master
Commit: 3ca65e888820a5f9e2b328449ae731e61a176b22
Parents: b91d8a6 1b1ad62
Author: Ian Dunlop <ia...@manchester.ac.uk>
Authored: Wed Oct 5 17:01:54 2016 +0100
Committer: Ian Dunlop <ia...@manchester.ac.uk>
Committed: Wed Oct 5 17:01:54 2016 +0100
----------------------------------------------------------------------
.../taverna/mobile/ui/workflow/WorkflowFragment.java | 10 ++++++----
app/src/main/res/layout/item_progressbar.xml | 2 +-
2 files changed, 7 insertions(+), 5 deletions(-)
----------------------------------------------------------------------