You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/05 12:06:22 UTC

[GitHub] [airflow] uranusjr commented on a change in pull request #20669: Fix ECSProtocol compat shim inheritance

uranusjr commented on a change in pull request #20669:
URL: https://github.com/apache/airflow/pull/20669#discussion_r778768017



##########
File path: airflow/contrib/operators/ecs_operator.py
##########
@@ -19,26 +19,12 @@
 
 import warnings
 
-from airflow.providers.amazon.aws.operators.ecs import ECSOperator, ECSProtocol as NewECSProtocol  # noqa
-from airflow.typing_compat import Protocol, runtime_checkable
+from airflow.providers.amazon.aws.operators.ecs import ECSOperator, ECSProtocol

Review comment:
       Yeah, and I’m intentionally importing those deprecated ones so if someone imports this module (and misses the import-time deprecation warning), instantiating either class would also spit out a deprecation warning.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org