You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/07/25 05:08:08 UTC
[GitHub] [nifi] kent-nguyen opened a new pull request, #6243: Cache schema request result for reuse
kent-nguyen opened a new pull request, #6243:
URL: https://github.com/apache/nifi/pull/6243
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-00000](https://issues.apache.org/jira/browse/NIFI-00000)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 8
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on pull request #6243: NIFI-10192 Cache schema request result for reuse
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on PR #6243:
URL: https://github.com/apache/nifi/pull/6243#issuecomment-1228387627
@markap14 did the work [5955](https://github.com/apache/nifi/pull/5955), he would be the best to understand the issue and the side effects, ie. if this is the right fix or there needs to be an additional refactor which includes looking at the original fix again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #6243: NIFI-10192 Cache schema request result for reuse
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on PR #6243:
URL: https://github.com/apache/nifi/pull/6243#issuecomment-1238675186
Can this be closed if #6364 replaces it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on a diff in pull request #6243: NIFI-10192 Cache schema request result for reuse
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on code in PR #6243:
URL: https://github.com/apache/nifi/pull/6243#discussion_r957459853
##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/LookupRecord.java:
##########
@@ -536,6 +536,8 @@ public int getLookupCount() {
private class RecordPathReplacementStrategy implements ReplacementStrategy {
private int lookupCount = 0;
+ private ArrayList SCHEMA_LOOKUP_RESULT_CACHE = new ArrayList();
Review Comment:
Although this isn't a CheckStyle error, we usually reserve variable names in all caps to constants. Perhaps change to `schemaLookupResultCache`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #6243: Cache schema request result for reuse
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on PR #6243:
URL: https://github.com/apache/nifi/pull/6243#issuecomment-1194003212
Looks like you have some Checkstyle errors, please run your maven command with the `-Pcontrib-check` before pushing commits, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] chnorton commented on pull request #6243: NIFI-10192 Cache schema request result for reuse
Posted by GitBox <gi...@apache.org>.
chnorton commented on PR #6243:
URL: https://github.com/apache/nifi/pull/6243#issuecomment-1221665744
Looks like all of the automated checks have passed - was there anything else that needs to be done before this can be accepted @mattyb149 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #6243: NIFI-10192 Cache schema request result for reuse
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on PR #6243:
URL: https://github.com/apache/nifi/pull/6243#issuecomment-1262719437
Closing based on comments, thanks @Aerilym!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #6243: NIFI-10192 Cache schema request result for reuse
Posted by GitBox <gi...@apache.org>.
exceptionfactory closed pull request #6243: NIFI-10192 Cache schema request result for reuse
URL: https://github.com/apache/nifi/pull/6243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] Aerilym commented on pull request #6243: NIFI-10192 Cache schema request result for reuse
Posted by GitBox <gi...@apache.org>.
Aerilym commented on PR #6243:
URL: https://github.com/apache/nifi/pull/6243#issuecomment-1239303648
> Can this be closed if #6364 replaces it?
Yes, this one can be closed, I have taken over the PR from @kent-nguyen and implemented a modified solution based on the given feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org