[jira] [Commented] (LUCENE-5176) remove _TestUtil.keepFullyDeletedSegments

["Hoss Man (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-5176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13739993#comment-13739993 ] 

Hoss Man commented on LUCENE-5176:
----------------------------------

bq. I dont understand why some tests like TestCachingWrapperFilter were using this.

Possibly just to help ensure that the code being tested _could_ handle this situation? (in the past, when it was a viable real world situation)

Just guessing though
                
> remove _TestUtil.keepFullyDeletedSegments
> -----------------------------------------
>
>                 Key: LUCENE-5176
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5176
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-5176.patch
>
>
> The few tests that need to test something here can use the index-writer pkg-private method.
> Other tests (like QueryUtils) can use a FilterAtomicReader to do their crazy tests.
> Otherwise, we risk lots of stupid false test failures.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org