[jira] [Resolved] (WHIMSY-220) Inconsistent and confusing return from ASF::Service.list method

["Sebb (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WHIMSY-220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb resolved WHIMSY-220.
-------------------------
    Resolution: Fixed

23ecb13  WHIMSY-220 Inconsistent and confusing return from ASF::Service.list method

> Inconsistent and confusing return from ASF::Service.list method
> ---------------------------------------------------------------
>
>                 Key: WHIMSY-220
>                 URL: https://issues.apache.org/jira/browse/WHIMSY-220
>             Project: Whimsy
>          Issue Type: Bug
>            Reporter: Sebb
>            Priority: Major
>
> The ASF::Service.list method returns only the service names, not a list of the objects.
> This disagrees with all the other list methods in the ldap.rb file.
> Further, the Service sub-class ASF::AppGroup overrides the method so it returns a list of objects.
> However the Service sub-class ASF::AuthGroup does not override list.
> This is very confusing.
> The list methods should be consistent.
> Note that several of the classes in the file which have list() methods also have listids() methods which just return the names of the objects.
> It would be better if ASF::Service.list were renamed ASF::Service.listids, and references to Service.list and AuthGroup.list were updated to use listids() where appropriate.
> Note: AFAICT the list() methods under discussion are only used in roster/model/group.rb currently, so the change would be minor.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)