You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/12/20 20:39:13 UTC

[GitHub] [calcite] vvysotskyi commented on a diff in pull request #3006: [CALCITE-5439] Validation of Pivot fails after creating a deep copy of SqlNode

vvysotskyi commented on code in PR #3006:
URL: https://github.com/apache/calcite/pull/3006#discussion_r1053728428


##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -6653,13 +6654,44 @@ private void checkLiteral2(String expression, String expected) {
         .withBigQuery().ok(expected);
   }
 
+  @Test void testPivotWithSqlShuttle() {

Review Comment:
   Agree, thanks, I moved the test there.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org