You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by pvillard31 <gi...@git.apache.org> on 2016/09/28 21:47:29 UTC
[GitHub] nifi pull request #1080: NIFI-766 Added icon on connection when backpressure...
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/1080
NIFI-766 Added icon on connection when backpressure is enabled
Here is a proposition to display an icon on a connection when back pressure is enabled.
At the moment, there is no icon displayed whether back pressure is configured or not. (I am not sure it is worth adding information that is not that important to users: back pressure is configured by default)
First time I take a shot at UI dev, please review with care ;)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pvillard31/nifi backpressure
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1080.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1080
----
commit 529492fa84013e877adf300826a85d6be5e9f5d0
Author: Pierre Villard <pi...@gmail.com>
Date: 2016-09-28T21:39:09Z
Added icon on connection when backpressure is enabled
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1080: NIFI-766 Added icon on connection when backpressure is ena...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1080
Can someone else finish up the review of this PR? I helped contribute to this PR and would prefer someone else's eyes on. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1080: NIFI-766 Added icon on connection when backpressure...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1080
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1080: NIFI-766 Added icon on connection when backpressure is ena...
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1080
@mcgilman @pvillard31 I made one slight change to ConnectionStatus to rename the getters/setters from setBackpressureDataSizeThresholdLong to setBackpressureBytesThreshold to align with the existing naming convention. Otherwise, all looks great! Tested and verified that all worked as expected. The UI looks great. Thanks for updating this, guys. It's been a long time coming and will be very helpful! +1 merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1080: NIFI-766 Added icon on connection when backpressure is ena...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1080
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1080: NIFI-766 Added icon on connection when backpressure is ena...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1080
@pvillard31,
Following some of the discussion on the mailing list recently and the original commentary on the JIRA [1], I'd like to propose shifting from an icon based approach when back pressure is engaged to a progress bar style approach where the user can quickly get a sense of how 'full' the queue is currently.
The mockup shows various configuration scenarios.
- Expiration (clock icon)
- Object and Data size backpressure (left and right bars respectively)
- Empty bar - backpressure not configured
- Partial bar - backpressure configured, partial represent precentage full
- Full solid bar - backpressure engaged
If you're up for some additional cycles on this PR I'd be happy to work through the changes with you. If not, I'm happy to take what you started and continue toward the mockup above.
Thanks!
[1] https://issues.apache.org/jira/browse/NIFI-766
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---