You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kevin Klues <kl...@gmail.com> on 2015/12/12 00:20:09 UTC

Review Request 41286: Update Getting Started for Mac OS X El Capitan

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41286/
-----------------------------------------------------------

Review request for mesos and Neil Conway.


Bugs: MESOS-4118
    https://issues.apache.org/jira/browse/MESOS-4118


Repository: mesos


Description
-------

The instructions for El Capitan are identical to Yosemite, with one
caveat: if upgrading from Yosemite to El Capitan, you need to rerun
'xcode-select --install'. This commit adds a note of this.


Diffs
-----

  docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb 

Diff: https://reviews.apache.org/r/41286/diff/


Testing
-------


Thanks,

Kevin Klues

Re: Review Request 41286: Updated Getting Started for Mac OS X El Capitan.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41286/#review110817
-----------------------------------------------------------

Ship it!


Ship It!

- Till Toenshoff


On Dec. 15, 2015, 1:09 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41286/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 1:09 a.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-4118
>     https://issues.apache.org/jira/browse/MESOS-4118
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The instructions for El Capitan are identical to Yosemite, with one
> caveat: if upgrading from Yosemite to El Capitan, you need to rerun
> 'xcode-select --install'. This commit adds a note of this.
> 
> 
> Diffs
> -----
> 
>   docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb 
> 
> Diff: https://reviews.apache.org/r/41286/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 41286: Updated Getting Started for Mac OS X El Capitan.

Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41286/
-----------------------------------------------------------

(Updated Dec. 15, 2015, 1:09 a.m.)


Review request for mesos and Neil Conway.


Summary (updated)
-----------------

Updated Getting Started for Mac OS X El Capitan.


Bugs: MESOS-4118
    https://issues.apache.org/jira/browse/MESOS-4118


Repository: mesos


Description
-------

The instructions for El Capitan are identical to Yosemite, with one
caveat: if upgrading from Yosemite to El Capitan, you need to rerun
'xcode-select --install'. This commit adds a note of this.


Diffs
-----

  docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb 

Diff: https://reviews.apache.org/r/41286/diff/


Testing
-------


Thanks,

Kevin Klues

Re: Review Request 41286: Update Getting Started for Mac OS X El Capitan

Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41286/
-----------------------------------------------------------

(Updated Dec. 14, 2015, 4:51 p.m.)


Review request for mesos and Neil Conway.


Bugs: MESOS-4118
    https://issues.apache.org/jira/browse/MESOS-4118


Repository: mesos


Description
-------

The instructions for El Capitan are identical to Yosemite, with one
caveat: if upgrading from Yosemite to El Capitan, you need to rerun
'xcode-select --install'. This commit adds a note of this.


Diffs
-----

  docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb 

Diff: https://reviews.apache.org/r/41286/diff/


Testing
-------


Thanks,

Kevin Klues

Re: Review Request 41286: Update Getting Started for Mac OS X El Capitan

Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41286/
-----------------------------------------------------------

(Updated Dec. 14, 2015, 4:50 p.m.)


Review request for mesos and Neil Conway.


Bugs: MESOS-4118
    https://issues.apache.org/jira/browse/MESOS-4118


Repository: mesos


Description
-------

The instructions for El Capitan are identical to Yosemite, with one
caveat: if upgrading from Yosemite to El Capitan, you need to rerun
'xcode-select --install'. This commit adds a note of this.


Diffs (updated)
-----

  docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb 

Diff: https://reviews.apache.org/r/41286/diff/


Testing
-------


Thanks,

Kevin Klues

Re: Review Request 41286: Update Getting Started for Mac OS X El Capitan

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41286/#review110225
-----------------------------------------------------------


Patch looks great!

Reviews applied: [41286]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 11, 2015, 11:20 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41286/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2015, 11:20 p.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-4118
>     https://issues.apache.org/jira/browse/MESOS-4118
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The instructions for El Capitan are identical to Yosemite, with one
> caveat: if upgrading from Yosemite to El Capitan, you need to rerun
> 'xcode-select --install'. This commit adds a note of this.
> 
> 
> Diffs
> -----
> 
>   docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb 
> 
> Diff: https://reviews.apache.org/r/41286/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 41286: Update Getting Started for Mac OS X El Capitan

Posted by Kevin Klues <kl...@gmail.com>.

> On Dec. 14, 2015, 9:43 a.m., Benjamin Bannier wrote:
> > docs/getting-started.md, line 57
> > <https://reviews.apache.org/r/41286/diff/1/?file=1160537#file1160537line57>
> >
> >     Not a native speaker, but shouldn't it be `s/If/When` here.
> >     
> >     Also, please `s/and rerun/to run/`.

I think we could go either way with If/When, but I'll change it. I think we want to say 're-run', not just 'run' because we are talking about running it a second time after the upgrade.  I agree with saying 'to' instead of 'and' though, that's just bad english.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41286/#review110184
-----------------------------------------------------------


On Dec. 14, 2015, 4:51 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41286/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2015, 4:51 p.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-4118
>     https://issues.apache.org/jira/browse/MESOS-4118
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The instructions for El Capitan are identical to Yosemite, with one
> caveat: if upgrading from Yosemite to El Capitan, you need to rerun
> 'xcode-select --install'. This commit adds a note of this.
> 
> 
> Diffs
> -----
> 
>   docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb 
> 
> Diff: https://reviews.apache.org/r/41286/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 41286: Update Getting Started for Mac OS X El Capitan

Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41286/#review110184
-----------------------------------------------------------



docs/getting-started.md (line 57)
<https://reviews.apache.org/r/41286/#comment169961>

    Not a native speaker, but shouldn't it be `s/If/When` here.
    
    Also, please `s/and rerun/to run/`.


- Benjamin Bannier


On Dec. 11, 2015, 11:20 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41286/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2015, 11:20 p.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-4118
>     https://issues.apache.org/jira/browse/MESOS-4118
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The instructions for El Capitan are identical to Yosemite, with one
> caveat: if upgrading from Yosemite to El Capitan, you need to rerun
> 'xcode-select --install'. This commit adds a note of this.
> 
> 
> Diffs
> -----
> 
>   docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb 
> 
> Diff: https://reviews.apache.org/r/41286/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>