You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/15 23:21:58 UTC

[GitHub] [arrow-datafusion] andygrove opened a new pull request, #3171: Prepare for 11.0.0 release

andygrove opened a new pull request, #3171:
URL: https://github.com/apache/arrow-datafusion/pull/3171

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Part of https://github.com/apache/arrow-datafusion/issues/3012
   
    # Rationale for this change
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   # What changes are included in this PR?
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   - The first commit has docs update
   - The second commit bumps the crate versions
   
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   Yes, version number changed.
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #3171: Prepare for 11.0.0 release

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3171:
URL: https://github.com/apache/arrow-datafusion/pull/3171#issuecomment-1215994979

   # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/3171?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3171](https://codecov.io/gh/apache/arrow-datafusion/pull/3171?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d7a0d8a) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/e57dead4222116850f0adc0074dcfd1e90c0b4ba?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e57dead) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #3171      +/-   ##
   ==========================================
   - Coverage   85.88%   85.88%   -0.01%     
   ==========================================
     Files         291      291              
     Lines       52770    52770              
   ==========================================
   - Hits        45321    45319       -2     
   - Misses       7449     7451       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/3171?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ” | |
   |---|---|---|
   | [datafusion/core/src/physical\_plan/metrics/value.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3171/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9waHlzaWNhbF9wbGFuL21ldHJpY3MvdmFsdWUucnM=) | `86.93% <0.00%> (-0.51%)` | :arrow_down: |
   | [datafusion/expr/src/logical\_plan/plan.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3171/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9sb2dpY2FsX3BsYW4vcGxhbi5ycw==) | `77.77% <0.00%> (-0.18%)` | :arrow_down: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] andygrove merged pull request #3171: Prepare for 11.0.0 release

Posted by GitBox <gi...@apache.org>.
andygrove merged PR #3171:
URL: https://github.com/apache/arrow-datafusion/pull/3171


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #3171: Prepare for 11.0.0 release

Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #3171:
URL: https://github.com/apache/arrow-datafusion/pull/3171#discussion_r946246998


##########
dev/release/README.md:
##########
@@ -23,7 +23,7 @@
 
 ### Major Release
 
-DataFusion typically has major releases from the `master` branch every 3 months, including breaking API changes.
+DataFusion typically has major releases from the `master` branch every 4 weeks, including breaking API changes.

Review Comment:
   πŸš„ 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #3171: Prepare for 11.0.0 release

Posted by GitBox <gi...@apache.org>.
alamb commented on PR #3171:
URL: https://github.com/apache/arrow-datafusion/pull/3171#issuecomment-1216024735

   Thanks for all the work to prepare the release @andygrove πŸ‘ 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #3171: Prepare for 11.0.0 release

Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #3171:
URL: https://github.com/apache/arrow-datafusion/pull/3171#discussion_r946882184


##########
datafusion/CHANGELOG.md:
##########
@@ -19,6 +19,250 @@
 
 # Changelog
 
+## [11.0.0](https://github.com/apache/arrow-datafusion/tree/11.0.0) (2022-08-16)
+
+[Full Changelog](https://github.com/apache/arrow-datafusion/compare/10.0.0-rc1...11.0.0)
+
+**Breaking changes:**

Review Comment:
   this list seems a little light πŸ˜†  but I don't think we should spend too much time cleaning this up



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] ursabot commented on pull request #3171: Prepare for 11.0.0 release

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3171:
URL: https://github.com/apache/arrow-datafusion/pull/3171#issuecomment-1216801061

   Benchmark runs are scheduled for baseline = 85f7fc9b262c5db9d17dfef662ee58d757c6eabf and contender = 8ee31cc69f43a4de0c0678d18a57f27cb4d0ead1. 8ee31cc69f43a4de0c0678d18a57f27cb4d0ead1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/22375e1ab0eb4ff688818a4e0b1f0a7f...00f51c813eab4d148203f1c71fb569a8/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/b889d3f88e344b1d8b9f58fa4b27d8eb...57819bad108a40d3b6ab2884079f6363/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/99a2bddac7424c6a927c5a74fd592c99...b6fa73661ace4bad8b05b46d062432ce/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/fea39388918947fbbcb25e0dff807c81...b624b713a5734d04bb7a9540dd12e383/)
   Buildkite builds:
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3171: Prepare for 11.0.0 release

Posted by GitBox <gi...@apache.org>.
andygrove commented on code in PR #3171:
URL: https://github.com/apache/arrow-datafusion/pull/3171#discussion_r946216479


##########
docs/source/index.rst:
##########
@@ -22,14 +22,6 @@ Apache Arrow DataFusion
 Table of Contents
 =================
 
-.. _toc.usage:
-
-.. toctree::
-   :maxdepth: 1
-   :caption: Supported Environments
-
-   Rust <https://docs.rs/crate/datafusion/>

Review Comment:
   This is the very first link on the page and takes the user to a completely different web site. I moved it down into the user guide.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #3171: Prepare for 11.0.0 release

Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #3171:
URL: https://github.com/apache/arrow-datafusion/pull/3171#discussion_r946247626


##########
docs/source/user-guide/sql/ddl.md:
##########
@@ -30,9 +30,17 @@ STORED AS PARQUET
 LOCATION '/mnt/nyctaxi/tripdata.parquet';
 ```
 
-CSV data sources can also be registered by executing a `CREATE EXTERNAL TABLE` SQL statement. It is necessary to
-provide schema information for CSV files since DataFusion does not automatically infer the schema when using SQL
-to query CSV files.
+CSV data sources can also be registered by executing a `CREATE EXTERNAL TABLE` SQL statement. The schema will be
+inferred based on scanning a subset of the file.
+
+```sql
+CREATE EXTERNAL TABLE test
+STORED AS CSV
+WITH HEADER ROW
+LOCATION '/path/to/aggregate_test_100.csv';

Review Comment:
   I didn't realize you could do this πŸ€” 
   
   I actually tried this particular example and it doesn't work: 
   
   ```
   ❯ CREATE EXTERNAL TABLE test
   STORED AS CSV
   WITH HEADER ROW
   LOCATION '../testing/data/csv/aggregate_test_100.csv';
   0 rows in set. Query took 0.102 seconds.
   ❯ select * from test;
   ArrowError(ParseError("Error while parsing value 14857091259186476033 for column 9 at line 3"))
   
   ```



##########
docs/source/user-guide/sql/ddl.md:
##########
@@ -30,9 +30,17 @@ STORED AS PARQUET
 LOCATION '/mnt/nyctaxi/tripdata.parquet';
 ```
 
-CSV data sources can also be registered by executing a `CREATE EXTERNAL TABLE` SQL statement. It is necessary to
-provide schema information for CSV files since DataFusion does not automatically infer the schema when using SQL
-to query CSV files.
+CSV data sources can also be registered by executing a `CREATE EXTERNAL TABLE` SQL statement. The schema will be
+inferred based on scanning a subset of the file.
+
+```sql
+CREATE EXTERNAL TABLE test
+STORED AS CSV
+WITH HEADER ROW
+LOCATION '/path/to/aggregate_test_100.csv';

Review Comment:
   ```suggestion
   LOCATION '/path/to/aggregate_simple.csv';
   ```
   
   But an alternate worked great: 
   
   ```sql
   ❯ CREATE EXTERNAL TABLE test
   STORED AS CSV
   WITH HEADER ROW
   LOCATION '../datafusion/core/tests/aggregate_simple.csv';
   0 rows in set. Query took 0.014 seconds.
   ❯ select * from test;
   +---------+----------------+-------+
   | c1      | c2             | c3    |
   +---------+----------------+-------+
   | 0.00001 | 0.000000000001 | true  |
   | 0.00002 | 0.000000000002 | false |
   | 0.00002 | 0.000000000002 | false |
   | 0.00003 | 0.000000000003 | true  |
   | 0.00003 | 0.000000000003 | true  |
   | 0.00003 | 0.000000000003 | true  |
   | 0.00004 | 0.000000000004 | false |
   | 0.00004 | 0.000000000004 | false |
   | 0.00004 | 0.000000000004 | false |
   | 0.00004 | 0.000000000004 | false |
   | 0.00005 | 0.000000000005 | true  |
   | 0.00005 | 0.000000000005 | true  |
   | 0.00005 | 0.000000000005 | true  |
   | 0.00005 | 0.000000000005 | true  |
   | 0.00005 | 0.000000000005 | true  |
   +---------+----------------+-------+
   ```
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3171: Prepare for 11.0.0 release

Posted by GitBox <gi...@apache.org>.
andygrove commented on code in PR #3171:
URL: https://github.com/apache/arrow-datafusion/pull/3171#discussion_r946284017


##########
docs/source/user-guide/sql/ddl.md:
##########
@@ -30,9 +30,17 @@ STORED AS PARQUET
 LOCATION '/mnt/nyctaxi/tripdata.parquet';
 ```
 
-CSV data sources can also be registered by executing a `CREATE EXTERNAL TABLE` SQL statement. It is necessary to
-provide schema information for CSV files since DataFusion does not automatically infer the schema when using SQL
-to query CSV files.
+CSV data sources can also be registered by executing a `CREATE EXTERNAL TABLE` SQL statement. The schema will be
+inferred based on scanning a subset of the file.
+
+```sql
+CREATE EXTERNAL TABLE test
+STORED AS CSV
+WITH HEADER ROW
+LOCATION '/path/to/aggregate_test_100.csv';

Review Comment:
   Thanks for testing that. Filed https://github.com/apache/arrow-datafusion/issues/3174



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] andygrove commented on pull request #3171: Prepare for 11.0.0 release

Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #3171:
URL: https://github.com/apache/arrow-datafusion/pull/3171#issuecomment-1216731722

   @alamb Now with CHANGELOG. I will go ahead and merge if there are no objections (once CI passes)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org