[GitHub] apucher closed pull request #3553: [TE] rootcause - preselect metric name in metric dropdown

[GitBox <gi...@apache.org>]

apucher closed pull request #3553: [TE] rootcause - preselect metric name in metric dropdown
URL: https://github.com/apache/incubator-pinot/pull/3553
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/thirdeye/thirdeye-frontend/app/pods/components/rootcause-select-metric/component.js b/thirdeye/thirdeye-frontend/app/pods/components/rootcause-select-metric/component.js
index 6428b7cfdc..d5c78af999 100644
--- a/thirdeye/thirdeye-frontend/app/pods/components/rootcause-select-metric/component.js
+++ b/thirdeye/thirdeye-frontend/app/pods/components/rootcause-select-metric/component.js
@@ -5,7 +5,7 @@ import { selfServeApiCommon } from 'thirdeye-frontend/utils/api/self-serve';
 import { task, timeout } from 'ember-concurrency';
 import _ from 'lodash';
 import { checkStatus } from 'thirdeye-frontend/utils/utils';
-import { get, set, computed, getProperties } from '@ember/object';
+import { computed, getProperties } from '@ember/object';
 export default Component.extend({
   classNames: ['rootcause-select-metric-dimension'],
 
@@ -48,12 +48,12 @@ export default Component.extend({
           return agg;
         });
       const relatedMetrics = filterPrefix(Object.keys(entities), 'thirdeye:metric:')
-      .filter(urn => urn in entities)
-      .map((urn) => {
-        const entity = entities[urn];
-        const agg = { alias: entity.label, id: entity.urn.split(':')[2] };
-        return agg;
-      });
+        .filter(urn => urn in entities)
+        .map((urn) => {
+          const entity = entities[urn];
+          const agg = { alias: entity.label, id: entity.urn.split(':')[2] };
+          return agg;
+        });
 
       return [
         { groupName: 'Selected Metrics', options: _.sortBy(selectedMetrics, (row) => row.alias) || [] },
@@ -132,6 +132,7 @@ export default Component.extend({
       if (selectionEditable && selectObj.isActive && selectObj.selected) {
         const selectInputEl = document.querySelector(searchInputSelector);
         selectInputEl.value = selectObj.selected.alias;
+        selectInputEl.select();
       }
     },
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org