You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/10 22:17:17 UTC

[GitHub] [incubator-superset] rusackas commented on a change in pull request #9462: [Dashboard] new listview filters & emotion infra

rusackas commented on a change in pull request #9462: [Dashboard] new listview filters & emotion infra
URL: https://github.com/apache/incubator-superset/pull/9462#discussion_r406957144
 
 

 ##########
 File path: superset-frontend/src/components/ListView/utils.ts
 ##########
 @@ -76,6 +87,13 @@ export function extractInputValue(
   return null;
 }
 
+export function getDefaultFilterOperator(filter: Filter): string {
+  if (filter.operator) return filter.operator;
 
 Review comment:
   ```suggestion
     if (filter?.operator) return filter.operator;
   ```
   just to be extra cautious 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org