You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "lostluck (via GitHub)" <gi...@apache.org> on 2023/08/11 17:58:06 UTC
[GitHub] [beam] lostluck opened a new pull request, #27974: Move beam website to most recent Hugo release (v0.117.0)
lostluck opened a new pull request, #27974:
URL: https://github.com/apache/beam/pull/27974
Our current hugo version v0.68.3 was released 3+ years ago, and the framework has improved since then. In particular, better error messages would be handy.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck merged pull request #27974: Move beam website to most recent Hugo release (v0.117.0)
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck merged PR #27974:
URL: https://github.com/apache/beam/pull/27974
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on a diff in pull request #27974: Move beam website to most recent Hugo release (v0.117.0)
Posted by "robertwb (via GitHub)" <gi...@apache.org>.
robertwb commented on code in PR #27974:
URL: https://github.com/apache/beam/pull/27974#discussion_r1291784823
##########
website/Dockerfile:
##########
@@ -29,6 +29,8 @@ ENV DEBIAN_FRONTEND=noninteractive \
LC_CTYPE=C.UTF-8 \
LC_MESSAGES=C.UTF-8
+WORKDIR /opt/
Review Comment:
Why this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #27974: Move beam website to most recent Hugo release (v0.117.0)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27974:
URL: https://github.com/apache/beam/pull/27974#issuecomment-1675206603
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #27974: Move beam website to most recent Hugo release (v0.117.0)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27974:
URL: https://github.com/apache/beam/pull/27974#issuecomment-1675392582
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on a diff in pull request #27974: Move beam website to most recent Hugo release (v0.117.0)
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on code in PR #27974:
URL: https://github.com/apache/beam/pull/27974#discussion_r1291787353
##########
website/Dockerfile:
##########
@@ -29,6 +29,8 @@ ENV DEBIAN_FRONTEND=noninteractive \
LC_CTYPE=C.UTF-8 \
LC_MESSAGES=C.UTF-8
+WORKDIR /opt/
Review Comment:
Without moving this earlier, npm fails with an otherwise inscrutable "ideal tree" error. This was the reported solution (setting a workdir, so in this case, it's set earlier).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #27974: Move beam website to most recent Hugo release (v0.117.0)
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #27974:
URL: https://github.com/apache/beam/pull/27974#issuecomment-1675391424
R: @robertwb
Just verified and now the error you ran into for the runner guide would have printed the following instead of panicking:
```
Error: error building site: assemble: "/opt/website/www/site/content/en/contribute/runner-guide.md:896:1": failed to extract shortcode: shortcode "highlight" does not evaluate .Inner or .InnerDeindent, yet a closing tag was provided
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #27974: Move beam website to most recent Hugo release (v0.117.0)
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #27974:
URL: https://github.com/apache/beam/pull/27974#issuecomment-1675390043
http://apache-beam-website-pull-requests.storage.googleapis.com/27974/index.html Navigating around the site, it looks good, so this is proably a safe update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org