You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/11/05 11:21:47 UTC
[GitHub] [bookkeeper] eolivelli opened a new pull request #2881: Fix flaky AutoRecoveryMainTest
eolivelli opened a new pull request #2881:
URL: https://github.com/apache/bookkeeper/pull/2881
Descriptions of the changes in this PR:
### Motivation
Sometimes the test AutoRecoveryMainTest fails this way on my test machine
```
[ERROR] org.apache.bookkeeper.replication.AutoRecoveryMainTest.testAutoRecoverySessionLoss Time elapsed: 1.757 s <<< FAILURE!
java.lang.AssertionError: autoRecoveryMain components should be running
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.apache.bookkeeper.replication.AutoRecoveryMainTest.startAutoRecoveryMain(AutoRecoveryMainTest.java:192)
at org.apache.bookkeeper.replication.AutoRecoveryMainTest.testAutoRecoverySessionLoss(AutoRecoveryMainTest.java:99)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.lang.Thread.run(Thread.java:748)
```
### Changes
Use `TestUtils.assertEventuallyTrue`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] zymap commented on pull request #2881: Fix flaky AutoRecoveryMainTest
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #2881:
URL: https://github.com/apache/bookkeeper/pull/2881#issuecomment-962745711
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli merged pull request #2881: Fix flaky AutoRecoveryMainTest
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #2881:
URL: https://github.com/apache/bookkeeper/pull/2881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org