You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Eugene Koifman <ek...@hortonworks.com> on 2018/10/09 23:38:54 UTC
Re: Review Request 68805: HIVE-20538
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68805/#review209387
-----------------------------------------------------------
ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommandsWithSplitUpdateAndVectorization.java
Line 25 (original), 30 (patched)
<https://reviews.apache.org/r/68805/#comment293781>
What is this change for? TestTxnCommands is a subclass of TxnCommandsBaseForTests. I think this means none of the TestTxnCommands tests run in vectorized mode any more
More generally, what is the point of other changes in this class?
- Eugene Koifman
On Sept. 21, 2018, 3:51 p.m., Jaume Marhuenda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68805/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2018, 3:51 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20538: Allow to store a key value together with a transaction.
>
>
> Diffs
> -----
>
> ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommandsWithSplitUpdateAndVectorization.java a013230025
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/CommitTxnKeyValue.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/CommitTxnRequest.java db47f9db8b
> standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php 936f7c5a40
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py 958f13c18e
> standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb a3dddf54e4
> standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java d226db50a5
> standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 54e7eda0da
> standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift ad83162ec3
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java 1df1ebce49
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnStore.java 080cc5284b
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java ce590d0f55
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTxns.java db4dd9ec42
>
>
> Diff: https://reviews.apache.org/r/68805/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jaume Marhuenda
>
>