[jira] [Commented] (MAPREDUCE-4359) Potential deadlock in Counters

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401390#comment-13401390 ] 

Hadoop QA commented on MAPREDUCE-4359:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12533475/MAPREDUCE-4359.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2515//console

This message is automatically generated.
                
> Potential deadlock in Counters
> ------------------------------
>
>                 Key: MAPREDUCE-4359
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4359
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 1.0.3
>            Reporter: Todd Lipcon
>            Assignee: Tom White
>         Attachments: 1_jcarder_result_0.dot.png, MAPREDUCE-4359.patch
>
>
> jcarder identified this deadlock in branch-1 (though it may also be present in trunk):
> - Counters.size() is synchronized and locks Counters before Group
> - Counters.Group.getCounterForName() is synchronized and calls through to Counters.size()
> This creates a potential cycle which could cause a deadlock (though probably quite rare in practice)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira