You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/09/03 21:41:41 UTC
Review Request 25311: Checking for cron jobs in startJobUpdate()
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25311/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Repository: aurora
Description
-------
Cron jobs should not be allowed in startJobUpdate().
Diffs
-----
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7a4640d8ca8a8a080368e27af5a1f6f83ea2f95d
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java f5682801902589552907415b4563af5b069af929
Diff: https://reviews.apache.org/r/25311/diff/
Testing
-------
gradle -Pq build
Thanks,
Maxim Khutornenko
Re: Review Request 25311: Checking for cron jobs in startJobUpdate()
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Sept. 3, 2014, 7:49 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 1343
> > <https://reviews.apache.org/r/25311/diff/1/?file=675806#file675806line1343>
> >
> > "Cron jobs may only be updated by calling replaceCronTemplate."
Sure, why not.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25311/#review52232
-----------------------------------------------------------
On Sept. 3, 2014, 7:41 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25311/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2014, 7:41 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Cron jobs should not be allowed in startJobUpdate().
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7a4640d8ca8a8a080368e27af5a1f6f83ea2f95d
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java f5682801902589552907415b4563af5b069af929
>
> Diff: https://reviews.apache.org/r/25311/diff/
>
>
> Testing
> -------
>
> gradle -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 25311: Checking for cron jobs in startJobUpdate()
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25311/#review52232
-----------------------------------------------------------
Ship it!
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
<https://reviews.apache.org/r/25311/#comment90973>
"Cron jobs may only be updated by calling replaceCronTemplate."
- Bill Farner
On Sept. 3, 2014, 7:41 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25311/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2014, 7:41 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Cron jobs should not be allowed in startJobUpdate().
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7a4640d8ca8a8a080368e27af5a1f6f83ea2f95d
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java f5682801902589552907415b4563af5b069af929
>
> Diff: https://reviews.apache.org/r/25311/diff/
>
>
> Testing
> -------
>
> gradle -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 25311: Checking for cron jobs in startJobUpdate()
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25311/
-----------------------------------------------------------
(Updated Sept. 3, 2014, 8:52 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
CR comments.
Repository: aurora
Description
-------
Cron jobs should not be allowed in startJobUpdate().
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7a4640d8ca8a8a080368e27af5a1f6f83ea2f95d
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java f5682801902589552907415b4563af5b069af929
Diff: https://reviews.apache.org/r/25311/diff/
Testing
-------
gradle -Pq build
Thanks,
Maxim Khutornenko