[GitHub] [netbeans] jlahoda commented on a change in pull request #2399: [NETBEANS-4832] Avoid assertion & NPE in fxml code completion

[GitBox <gi...@apache.org>]

jlahoda commented on a change in pull request #2399:
URL: https://github.com/apache/netbeans/pull/2399#discussion_r496389412



##########
File path: javafx/javafx2.editor/src/org/netbeans/modules/javafx2/editor/FXMLCompletion2.java
##########
@@ -161,6 +161,8 @@ public void run(ResultIterator resultIterator) throws Exception {
                 }
                 Parser.Result result = resultIterator.getParserResult();
                 ci = CompilationInfo.get(result);
+                // following populates module info, partial fix for [NETBEANS-4832]
+                ci.getElements().getPackageElement("java.lang");

Review comment:
       I think the expected way would be to get a CompilationController (instead of just CompilationInfo) and call toPhase(ELEMENTS_RESOLVED), or alike, on it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists