You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Aleksandr Kovalenko <ak...@hortonworks.com> on 2017/03/03 15:08:27 UTC
Review Request 57290: Despite user selecting not to apply Config
Changes, Changes are being applied
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57290/
-----------------------------------------------------------
Review request for Ambari and Alexandr Antonenko.
Bugs: AMBARI-20302
https://issues.apache.org/jira/browse/AMBARI-20302
Repository: ambari
Description
-------
Steps:
1) On an existing cluster, Delete Ambari Infra service
2) At time of deletion , there will be a popup which shows Recommended Config changes
3) Unselect the recommended config change and continue
Expected:
Config change should not be applied
Acutal:
Config change was applied regardless
Refer to screenshot for the example config which got changed
Diffs
-----
ambari-web/app/controllers/main/service/item.js 621c3b6
ambari-web/test/controllers/main/service/item_test.js fff321c
Diff: https://reviews.apache.org/r/57290/diff/1/
Testing
-------
20575 passing (33s)
153 pending
Thanks,
Aleksandr Kovalenko
Re: Review Request 57290: Despite user selecting not to apply Config
Changes, Changes are being applied
Posted by Alexandr Antonenko <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57290/#review167830
-----------------------------------------------------------
Ship it!
Ship It!
- Alexandr Antonenko
On March 3, 2017, 3:08 p.m., Aleksandr Kovalenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57290/
> -----------------------------------------------------------
>
> (Updated March 3, 2017, 3:08 p.m.)
>
>
> Review request for Ambari and Alexandr Antonenko.
>
>
> Bugs: AMBARI-20302
> https://issues.apache.org/jira/browse/AMBARI-20302
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Steps:
> 1) On an existing cluster, Delete Ambari Infra service
> 2) At time of deletion , there will be a popup which shows Recommended Config changes
> 3) Unselect the recommended config change and continue
> Expected:
> Config change should not be applied
> Acutal:
> Config change was applied regardless
> Refer to screenshot for the example config which got changed
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service/item.js 621c3b6
> ambari-web/test/controllers/main/service/item_test.js fff321c
>
>
> Diff: https://reviews.apache.org/r/57290/diff/1/
>
>
> Testing
> -------
>
> 20575 passing (33s)
> 153 pending
>
>
> Thanks,
>
> Aleksandr Kovalenko
>
>