You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "L. Kluitmann (JIRA)" <ji...@apache.org> on 2011/03/02 15:20:36 UTC
[jira] Created: (WICKET-3493) Login doesn't work if placing the
SignInPanel on the HomePage.
Login doesn't work if placing the SignInPanel on the HomePage.
---------------------------------------------------------------
Key: WICKET-3493
URL: https://issues.apache.org/jira/browse/WICKET-3493
Project: Wicket
Issue Type: Bug
Components: wicket-auth-roles, wicket-examples
Affects Versions: 1.5-RC2
Environment: Ubuntu 10.04 and Wicket 1.5 latest trunk
Reporter: L. Kluitmann
Priority: Minor
I did some minor changes to wicket example authentication3. I put the SignInPanel on the HomePage. The changes look like this:
HomePage.java
public HomePage() {
super();
add(new SignInPanel("signin", true));
}
HomePage.html
<br><br>
<div wicket:id="signin"></div>
Now you can see the SignInPanel on the HomePage. If you login you are redirected to the home page again. Everything seems to be fine. But if you click the Admin Page link you are redirected to the login page. I think you should end-up on the Admin Page itself because the login was correct.
That means also, you cannot use the SignInPanel on your application's home page for user login.
Regards
Ludger
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-3493) Login doesn't work if placing the
SignInPanel on the HomePage.
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008336#comment-13008336 ]
Igor Vaynberg commented on WICKET-3493:
---------------------------------------
main problem fixed. session was not binding itself explicitly on signin and because home page is stateless the signedin flag was not being persisted.
> Login doesn't work if placing the SignInPanel on the HomePage.
> ---------------------------------------------------------------
>
> Key: WICKET-3493
> URL: https://issues.apache.org/jira/browse/WICKET-3493
> Project: Wicket
> Issue Type: Bug
> Components: wicket-auth-roles, wicket-examples
> Affects Versions: 1.5-RC2
> Environment: Ubuntu 10.04 and Wicket 1.5 latest trunk
> Reporter: Ludger Kluitmann
> Assignee: Igor Vaynberg
> Priority: Minor
> Labels: wicket
> Fix For: 1.5-RC3
>
> Attachments: quick1.zip
>
>
> I did some minor changes to wicket example authentication3. I put the SignInPanel on the HomePage. The changes look like this:
> HomePage.java
> public HomePage() {
> super();
>
> add(new SignInPanel("signin", true));
> }
> HomePage.html
> <br><br>
> <div wicket:id="signin"></div>
> Now you can see the SignInPanel on the HomePage. If you login you are redirected to the home page again. Everything seems to be fine. But if you click the Admin Page link you are redirected to the login page. I think you should end-up on the Admin Page itself because the login was correct.
> That means also, you cannot use the SignInPanel on your application's home page for user login.
> Regards
> Ludger
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (WICKET-3493) Login doesn't work if placing the
SignInPanel on the HomePage.
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-3493.
-----------------------------------
Resolution: Fixed
> Login doesn't work if placing the SignInPanel on the HomePage.
> ---------------------------------------------------------------
>
> Key: WICKET-3493
> URL: https://issues.apache.org/jira/browse/WICKET-3493
> Project: Wicket
> Issue Type: Bug
> Components: wicket-auth-roles, wicket-examples
> Affects Versions: 1.5-RC2
> Environment: Ubuntu 10.04 and Wicket 1.5 latest trunk
> Reporter: Ludger Kluitmann
> Assignee: Igor Vaynberg
> Priority: Minor
> Labels: wicket
> Fix For: 1.5-RC3
>
> Attachments: quick1.zip
>
>
> I did some minor changes to wicket example authentication3. I put the SignInPanel on the HomePage. The changes look like this:
> HomePage.java
> public HomePage() {
> super();
>
> add(new SignInPanel("signin", true));
> }
> HomePage.html
> <br><br>
> <div wicket:id="signin"></div>
> Now you can see the SignInPanel on the HomePage. If you login you are redirected to the home page again. Everything seems to be fine. But if you click the Admin Page link you are redirected to the login page. I think you should end-up on the Admin Page itself because the login was correct.
> That means also, you cannot use the SignInPanel on your application's home page for user login.
> Regards
> Ludger
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (WICKET-3493) Login doesn't work if placing the
SignInPanel on the HomePage.
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-3493.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.5-RC3
Assignee: Igor Vaynberg
> Login doesn't work if placing the SignInPanel on the HomePage.
> ---------------------------------------------------------------
>
> Key: WICKET-3493
> URL: https://issues.apache.org/jira/browse/WICKET-3493
> Project: Wicket
> Issue Type: Bug
> Components: wicket-auth-roles, wicket-examples
> Affects Versions: 1.5-RC2
> Environment: Ubuntu 10.04 and Wicket 1.5 latest trunk
> Reporter: L. Kluitmann
> Assignee: Igor Vaynberg
> Priority: Minor
> Labels: wicket
> Fix For: 1.5-RC3
>
>
> I did some minor changes to wicket example authentication3. I put the SignInPanel on the HomePage. The changes look like this:
> HomePage.java
> public HomePage() {
> super();
>
> add(new SignInPanel("signin", true));
> }
> HomePage.html
> <br><br>
> <div wicket:id="signin"></div>
> Now you can see the SignInPanel on the HomePage. If you login you are redirected to the home page again. Everything seems to be fine. But if you click the Admin Page link you are redirected to the login page. I think you should end-up on the Admin Page itself because the login was correct.
> That means also, you cannot use the SignInPanel on your application's home page for user login.
> Regards
> Ludger
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-3493) Login doesn't work if placing the
SignInPanel on the HomePage.
Posted by "L. Kluitmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004425#comment-13004425 ]
L. Kluitmann commented on WICKET-3493:
--------------------------------------
Now we have a complex behavior. Follow these steps:
1. Login on the HomePage -> you are redirected to HomePage. OK! But cookie (remember me was checked) not set. Not OK!
2. Click admin link -> redirected to login page. Not OK!
3. Click back button of your browser or use the back gesture -> Back to HomePage, of course.
4. Login again -> redirected to AdminPage and cookie is set. OK but very strange behavior
After SignOut you are able to reproduce the steps.
> Login doesn't work if placing the SignInPanel on the HomePage.
> ---------------------------------------------------------------
>
> Key: WICKET-3493
> URL: https://issues.apache.org/jira/browse/WICKET-3493
> Project: Wicket
> Issue Type: Bug
> Components: wicket-auth-roles, wicket-examples
> Affects Versions: 1.5-RC2
> Environment: Ubuntu 10.04 and Wicket 1.5 latest trunk
> Reporter: L. Kluitmann
> Assignee: Igor Vaynberg
> Priority: Minor
> Labels: wicket
> Fix For: 1.5-RC3
>
>
> I did some minor changes to wicket example authentication3. I put the SignInPanel on the HomePage. The changes look like this:
> HomePage.java
> public HomePage() {
> super();
>
> add(new SignInPanel("signin", true));
> }
> HomePage.html
> <br><br>
> <div wicket:id="signin"></div>
> Now you can see the SignInPanel on the HomePage. If you login you are redirected to the home page again. Everything seems to be fine. But if you click the Admin Page link you are redirected to the login page. I think you should end-up on the Admin Page itself because the login was correct.
> That means also, you cannot use the SignInPanel on your application's home page for user login.
> Regards
> Ludger
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (WICKET-3493) Login doesn't work if placing the
SignInPanel on the HomePage.
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg reopened WICKET-3493:
-----------------------------------
> Login doesn't work if placing the SignInPanel on the HomePage.
> ---------------------------------------------------------------
>
> Key: WICKET-3493
> URL: https://issues.apache.org/jira/browse/WICKET-3493
> Project: Wicket
> Issue Type: Bug
> Components: wicket-auth-roles, wicket-examples
> Affects Versions: 1.5-RC2
> Environment: Ubuntu 10.04 and Wicket 1.5 latest trunk
> Reporter: L. Kluitmann
> Assignee: Igor Vaynberg
> Priority: Minor
> Labels: wicket
> Fix For: 1.5-RC3
>
>
> I did some minor changes to wicket example authentication3. I put the SignInPanel on the HomePage. The changes look like this:
> HomePage.java
> public HomePage() {
> super();
>
> add(new SignInPanel("signin", true));
> }
> HomePage.html
> <br><br>
> <div wicket:id="signin"></div>
> Now you can see the SignInPanel on the HomePage. If you login you are redirected to the home page again. Everything seems to be fine. But if you click the Admin Page link you are redirected to the login page. I think you should end-up on the Admin Page itself because the login was correct.
> That means also, you cannot use the SignInPanel on your application's home page for user login.
> Regards
> Ludger
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-3493) Login doesn't work if placing the
SignInPanel on the HomePage.
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008332#comment-13008332 ]
Igor Vaynberg commented on WICKET-3493:
---------------------------------------
@Jim, the behavior in your attached quickstart is the correct one. since you are throwing the RRIPE from inside the listener the listener will be resumed when you execute continueToOriginalDestination(). if you were truly intercepting a page destination you would throw RRIPE no later then page's constructor.
the behavior you are experiencing here is something we tried hard to achieve as it was requested numerous times. a specific example was that our users wanted to intercept the processing of a form, etc.
the quickstart you have provided has nothing to do with the original problem described in this issue.
> Login doesn't work if placing the SignInPanel on the HomePage.
> ---------------------------------------------------------------
>
> Key: WICKET-3493
> URL: https://issues.apache.org/jira/browse/WICKET-3493
> Project: Wicket
> Issue Type: Bug
> Components: wicket-auth-roles, wicket-examples
> Affects Versions: 1.5-RC2
> Environment: Ubuntu 10.04 and Wicket 1.5 latest trunk
> Reporter: Ludger Kluitmann
> Assignee: Igor Vaynberg
> Priority: Minor
> Labels: wicket
> Fix For: 1.5-RC3
>
> Attachments: quick1.zip
>
>
> I did some minor changes to wicket example authentication3. I put the SignInPanel on the HomePage. The changes look like this:
> HomePage.java
> public HomePage() {
> super();
>
> add(new SignInPanel("signin", true));
> }
> HomePage.html
> <br><br>
> <div wicket:id="signin"></div>
> Now you can see the SignInPanel on the HomePage. If you login you are redirected to the home page again. Everything seems to be fine. But if you click the Admin Page link you are redirected to the login page. I think you should end-up on the Admin Page itself because the login was correct.
> That means also, you cannot use the SignInPanel on your application's home page for user login.
> Regards
> Ludger
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-3493) Login doesn't work if placing the
SignInPanel on the HomePage.
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008107#comment-13008107 ]
Martin Grigorov commented on WICKET-3493:
-----------------------------------------
No need to use Git. You can see the changes here: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/RestartResponseAtInterceptPageException.java?view=log
I tried to bisect it but the problem is not in this class. I reverted to an year back and the behavior is the same.
> Login doesn't work if placing the SignInPanel on the HomePage.
> ---------------------------------------------------------------
>
> Key: WICKET-3493
> URL: https://issues.apache.org/jira/browse/WICKET-3493
> Project: Wicket
> Issue Type: Bug
> Components: wicket-auth-roles, wicket-examples
> Affects Versions: 1.5-RC2
> Environment: Ubuntu 10.04 and Wicket 1.5 latest trunk
> Reporter: Ludger Kluitmann
> Assignee: Igor Vaynberg
> Priority: Minor
> Labels: wicket
> Fix For: 1.5-RC3
>
> Attachments: quick1.zip
>
>
> I did some minor changes to wicket example authentication3. I put the SignInPanel on the HomePage. The changes look like this:
> HomePage.java
> public HomePage() {
> super();
>
> add(new SignInPanel("signin", true));
> }
> HomePage.html
> <br><br>
> <div wicket:id="signin"></div>
> Now you can see the SignInPanel on the HomePage. If you login you are redirected to the home page again. Everything seems to be fine. But if you click the Admin Page link you are redirected to the login page. I think you should end-up on the Admin Page itself because the login was correct.
> That means also, you cannot use the SignInPanel on your application's home page for user login.
> Regards
> Ludger
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WICKET-3493) Login doesn't work if placing the
SignInPanel on the HomePage.
Posted by "Jim Pinkham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Pinkham updated WICKET-3493:
--------------------------------
Attachment: quick1.zip
This demonstrates the issue. I think it is the same issue, which started sometime between 1.5-M3 and 1.5-RC1 when I first noticed it. It remains here in rc2.
> Login doesn't work if placing the SignInPanel on the HomePage.
> ---------------------------------------------------------------
>
> Key: WICKET-3493
> URL: https://issues.apache.org/jira/browse/WICKET-3493
> Project: Wicket
> Issue Type: Bug
> Components: wicket-auth-roles, wicket-examples
> Affects Versions: 1.5-RC2
> Environment: Ubuntu 10.04 and Wicket 1.5 latest trunk
> Reporter: Ludger Kluitmann
> Assignee: Igor Vaynberg
> Priority: Minor
> Labels: wicket
> Fix For: 1.5-RC3
>
> Attachments: quick1.zip
>
>
> I did some minor changes to wicket example authentication3. I put the SignInPanel on the HomePage. The changes look like this:
> HomePage.java
> public HomePage() {
> super();
>
> add(new SignInPanel("signin", true));
> }
> HomePage.html
> <br><br>
> <div wicket:id="signin"></div>
> Now you can see the SignInPanel on the HomePage. If you login you are redirected to the home page again. Everything seems to be fine. But if you click the Admin Page link you are redirected to the login page. I think you should end-up on the Admin Page itself because the login was correct.
> That means also, you cannot use the SignInPanel on your application's home page for user login.
> Regards
> Ludger
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WICKET-3493) Login doesn't work if placing the
SignInPanel on the HomePage.
Posted by "Jim Pinkham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Pinkham updated WICKET-3493:
--------------------------------
Attachment: RestartResponseAtInterceptPageException.java
It's quite the hack, but it works around the issue for me till more familiar eyes than mine find time to look at this.
> Login doesn't work if placing the SignInPanel on the HomePage.
> ---------------------------------------------------------------
>
> Key: WICKET-3493
> URL: https://issues.apache.org/jira/browse/WICKET-3493
> Project: Wicket
> Issue Type: Bug
> Components: wicket-auth-roles, wicket-examples
> Affects Versions: 1.5-RC2
> Environment: Ubuntu 10.04 and Wicket 1.5 latest trunk
> Reporter: Ludger Kluitmann
> Assignee: Igor Vaynberg
> Priority: Minor
> Labels: wicket
> Fix For: 1.5-RC3
>
> Attachments: RestartResponseAtInterceptPageException.java, quick1.zip
>
>
> I did some minor changes to wicket example authentication3. I put the SignInPanel on the HomePage. The changes look like this:
> HomePage.java
> public HomePage() {
> super();
>
> add(new SignInPanel("signin", true));
> }
> HomePage.html
> <br><br>
> <div wicket:id="signin"></div>
> Now you can see the SignInPanel on the HomePage. If you login you are redirected to the home page again. Everything seems to be fine. But if you click the Admin Page link you are redirected to the login page. I think you should end-up on the Admin Page itself because the login was correct.
> That means also, you cannot use the SignInPanel on your application's home page for user login.
> Regards
> Ludger
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-3493) Login doesn't work if placing the
SignInPanel on the HomePage.
Posted by "Jim Pinkham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008098#comment-13008098 ]
Jim Pinkham commented on WICKET-3493:
-------------------------------------
Oh, and by the way, the quickstart is minimal so it doesn't even have wicket-auth-roles.
I think the problem is with the RestartResponseAtInterceptPageException class, but I haven't learned git yet to view it's change history.
> Login doesn't work if placing the SignInPanel on the HomePage.
> ---------------------------------------------------------------
>
> Key: WICKET-3493
> URL: https://issues.apache.org/jira/browse/WICKET-3493
> Project: Wicket
> Issue Type: Bug
> Components: wicket-auth-roles, wicket-examples
> Affects Versions: 1.5-RC2
> Environment: Ubuntu 10.04 and Wicket 1.5 latest trunk
> Reporter: Ludger Kluitmann
> Assignee: Igor Vaynberg
> Priority: Minor
> Labels: wicket
> Fix For: 1.5-RC3
>
> Attachments: quick1.zip
>
>
> I did some minor changes to wicket example authentication3. I put the SignInPanel on the HomePage. The changes look like this:
> HomePage.java
> public HomePage() {
> super();
>
> add(new SignInPanel("signin", true));
> }
> HomePage.html
> <br><br>
> <div wicket:id="signin"></div>
> Now you can see the SignInPanel on the HomePage. If you login you are redirected to the home page again. Everything seems to be fine. But if you click the Admin Page link you are redirected to the login page. I think you should end-up on the Admin Page itself because the login was correct.
> That means also, you cannot use the SignInPanel on your application's home page for user login.
> Regards
> Ludger
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira