You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Ryota Egashira <eg...@yahoo-inc.com> on 2014/03/18 17:35:18 UTC
Review Request 19359: OOZIE-1725 add coord:formatTime() to EL functions set
used in SLA tag
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19359/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-1725
https://issues.apache.org/jira/browse/OOZIE-1725
Repository: oozie-git
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1725
Diffs
-----
core/src/main/resources/oozie-default.xml 34362aa
core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java 34a428f
Diff: https://reviews.apache.org/r/19359/diff/
Testing
-------
Thanks,
Ryota Egashira
Re: Review Request 19359: OOZIE-1725 add coord:formatTime() to EL functions
set used in SLA tag
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19359/#review38224
-----------------------------------------------------------
Ship it!
Ship It!
- Rohini Palaniswamy
On March 21, 2014, 10:42 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19359/
> -----------------------------------------------------------
>
> (Updated March 21, 2014, 10:42 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1725
> https://issues.apache.org/jira/browse/OOZIE-1725
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1725
>
>
> Diffs
> -----
>
> core/src/main/resources/oozie-default.xml 34362aa
> core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java 34a428f
> core/src/test/java/org/apache/oozie/coord/TestHCatELFunctions.java f46f1ec
>
> Diff: https://reviews.apache.org/r/19359/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 19359: OOZIE-1725 add coord:formatTime() to EL functions
set used in SLA tag
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19359/#review38920
-----------------------------------------------------------
Ship it!
Please remove the debug System.out.println messages and upload patch to jira.
core/src/main/java/org/apache/oozie/coord/CoordELEvaluator.java
<https://reviews.apache.org/r/19359/#comment71243>
To be removed
core/src/main/java/org/apache/oozie/coord/CoordELEvaluator.java
<https://reviews.apache.org/r/19359/#comment71244>
To be removed
- Rohini Palaniswamy
On March 28, 2014, 3:44 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19359/
> -----------------------------------------------------------
>
> (Updated March 28, 2014, 3:44 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1725
> https://issues.apache.org/jira/browse/OOZIE-1725
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1725
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java b00eb7b
> core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 9e6a3d5
> core/src/main/java/org/apache/oozie/coord/CoordELEvaluator.java 0341aa1
> core/src/main/resources/oozie-default.xml 34362aa
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java c5a04d7
> core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java 8dc0c44
> core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java 34a428f
> core/src/test/java/org/apache/oozie/coord/TestHCatELFunctions.java f46f1ec
>
> Diff: https://reviews.apache.org/r/19359/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 19359: OOZIE-1725 add coord:formatTime() to EL functions
set used in SLA tag
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19359/
-----------------------------------------------------------
(Updated March 28, 2014, 3:44 p.m.)
Review request for oozie.
Changes
-------
added assertion of entire sla notification message in TestCoordActionMaterializeCommand.testActionMater
Bugs: OOZIE-1725
https://issues.apache.org/jira/browse/OOZIE-1725
Repository: oozie-git
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1725
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java b00eb7b
core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 9e6a3d5
core/src/main/java/org/apache/oozie/coord/CoordELEvaluator.java 0341aa1
core/src/main/resources/oozie-default.xml 34362aa
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java c5a04d7
core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java 8dc0c44
core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java 34a428f
core/src/test/java/org/apache/oozie/coord/TestHCatELFunctions.java f46f1ec
Diff: https://reviews.apache.org/r/19359/diff/
Testing
-------
Thanks,
Ryota Egashira
Re: Review Request 19359: OOZIE-1725 add coord:formatTime() to EL functions
set used in SLA tag
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19359/
-----------------------------------------------------------
(Updated March 27, 2014, 10:07 p.m.)
Review request for oozie.
Changes
-------
modified TestCoordActionMaterializeCommand to add couple of assertions
Bugs: OOZIE-1725
https://issues.apache.org/jira/browse/OOZIE-1725
Repository: oozie-git
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1725
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java b00eb7b
core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 9e6a3d5
core/src/main/java/org/apache/oozie/coord/CoordELEvaluator.java 0341aa1
core/src/main/resources/oozie-default.xml 34362aa
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java c5a04d7
core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java 8dc0c44
core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java 34a428f
core/src/test/java/org/apache/oozie/coord/TestHCatELFunctions.java f46f1ec
Diff: https://reviews.apache.org/r/19359/diff/
Testing
-------
Thanks,
Ryota Egashira
Re: Review Request 19359: OOZIE-1725 add coord:formatTime() to EL functions
set used in SLA tag
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19359/
-----------------------------------------------------------
(Updated March 26, 2014, 11:40 p.m.)
Review request for oozie.
Changes
-------
added more safeguard by checking all EL functions (added by this patch) in TestCoordSubmitXCommand/TestCoordActionMaterializeCommand.
Bugs: OOZIE-1725
https://issues.apache.org/jira/browse/OOZIE-1725
Repository: oozie-git
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1725
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java b00eb7b
core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 9e6a3d5
core/src/main/java/org/apache/oozie/coord/CoordELEvaluator.java 0341aa1
core/src/main/resources/oozie-default.xml 34362aa
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java c5a04d7
core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java 8dc0c44
core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java 34a428f
core/src/test/java/org/apache/oozie/coord/TestHCatELFunctions.java f46f1ec
Diff: https://reviews.apache.org/r/19359/diff/
Testing
-------
Thanks,
Ryota Egashira
Re: Review Request 19359: OOZIE-1725 add coord:formatTime() to EL functions
set used in SLA tag
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19359/
-----------------------------------------------------------
(Updated March 26, 2014, 12:17 a.m.)
Review request for oozie.
Changes
-------
found bug where dataOut/actualTime, etc don't work as expected and fixed these.
Bugs: OOZIE-1725
https://issues.apache.org/jira/browse/OOZIE-1725
Repository: oozie-git
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1725
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java b00eb7b
core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 9e6a3d5
core/src/main/java/org/apache/oozie/coord/CoordELEvaluator.java 0341aa1
core/src/main/resources/oozie-default.xml 34362aa
core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java 34a428f
core/src/test/java/org/apache/oozie/coord/TestHCatELFunctions.java f46f1ec
Diff: https://reviews.apache.org/r/19359/diff/
Testing
-------
Thanks,
Ryota Egashira
Re: Review Request 19359: OOZIE-1725 add coord:formatTime() to EL functions
set used in SLA tag
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19359/
-----------------------------------------------------------
(Updated March 21, 2014, 10:42 p.m.)
Review request for oozie.
Changes
-------
adding other EL functions that can be used in SLA tag.
Bugs: OOZIE-1725
https://issues.apache.org/jira/browse/OOZIE-1725
Repository: oozie-git
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1725
Diffs (updated)
-----
core/src/main/resources/oozie-default.xml 34362aa
core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java 34a428f
core/src/test/java/org/apache/oozie/coord/TestHCatELFunctions.java f46f1ec
Diff: https://reviews.apache.org/r/19359/diff/
Testing
-------
Thanks,
Ryota Egashira