[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #6373: Logs change

[GitBox <gi...@apache.org>]

rawlinp commented on a change in pull request #6373:
URL: https://github.com/apache/trafficcontrol/pull/6373#discussion_r754416675



##########
File path: traffic_ops/app/db/migrations/2021112117412459_logs_change.up.sql
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership.  The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+
+CREATE TABLE public.log_new (
+	"message" text NOT NULL,
+	"user" bigint NOT NULL,
+	"date" timestamp with time zone NOT NULL DEFAULT NOW()

Review comment:
       `last_updated` is kind of ubiquitous in our API, even though it doesn't necessarily make sense for non-updatable things. Making it unique in this sense means we can't easily reuse queries for things like IMS using the ubiquitous `last_updated` column.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org