[GitHub] [couchdb] nickva opened a new pull request #3182: Fix transient replication jobs failure handling

[GitBox <gi...@apache.org>]

nickva opened a new pull request #3182:
URL: https://github.com/apache/couchdb/pull/3182


   There are two fixes:
   
   1)  Fix transient replication job state wait logic
   
   Make sure to handle both `finished` and `pending` states when waiting for a
   transient jobs. A transient job will go to the `failed` state if it cannot
   fetch the filter from the source endpoint. For completeness, we also account
   for `pending` states in there in the remote chance the job get rescheduled
   again.
   
   2) Fix error reporting when fetching replication filters
   
   Don't unnecessarily unwrap the fetch error since `error_info/1` can already
   handle the current shape. Also, make sure to translate the reason to binary for
   consistency with the other filter fetching errors in the
   `couch_replicator_filters` module.
   
   The end-to-end test in the second commits checks the waiting behavior and the error reporting.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] nickva merged pull request #3182: Fix transient replication jobs failure handling

[GitBox <gi...@apache.org>]

nickva merged pull request #3182:
URL: https://github.com/apache/couchdb/pull/3182


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org