You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/01/04 14:15:15 UTC

[GitHub] [apisix-dashboard] imjoey opened a new pull request #1200: fix: Support version/githash for target api-run

imjoey opened a new pull request #1200:
URL: https://github.com/apache/apisix-dashboard/pull/1200


   Signed-off-by: imjoey <ma...@gmail.com>
   
   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [x] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   
   Fixes #1185 .
   
   ___
   ### Bugfix
   - Description
   
   As described in #1185 , currently running `make api-run` cannot show out the relevant `Version` and `GitHash` details. The reason is not setting `-ldflags` for `go run` command.
   
   - How to fix?
   
   This PR is going to add missing output values for `api-run`, via running an enhance version of `api/build.sh`. The new build script could support the dry-run mode without `go build`.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1200: fix: Support version/githash for make api-run command

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1200:
URL: https://github.com/apache/apisix-dashboard/pull/1200


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] imjoey edited a comment on pull request #1200: fix: Support version/githash for make api-run command

Posted by GitBox <gi...@apache.org>.
imjoey edited a comment on pull request #1200:
URL: https://github.com/apache/apisix-dashboard/pull/1200#issuecomment-754009748


   ping @juzhiyuan @liuxiran @starsz  @nic-chen for reviewing. Any comments are welcome. Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] imjoey commented on pull request #1200: fix: Support version/githash for make api-run command

Posted by GitBox <gi...@apache.org>.
imjoey commented on pull request #1200:
URL: https://github.com/apache/apisix-dashboard/pull/1200#issuecomment-754009748


   ping @juzhiyuan @liuxiran @nic-chen for reviewing. Any comments are welcome. Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] imjoey commented on pull request #1200: fix: Support version/githash for make api-run command

Posted by GitBox <gi...@apache.org>.
imjoey commented on pull request #1200:
URL: https://github.com/apache/apisix-dashboard/pull/1200#issuecomment-754058397


   @tokers Thank you so much for reviewing.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org