You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/11 10:00:31 UTC

[GitHub] [airflow] AlessioM commented on a change in pull request #13536: Fix string encoding in DockerOperator when using xcom / json

AlessioM commented on a change in pull request #13536:
URL: https://github.com/apache/airflow/pull/13536#discussion_r554932857



##########
File path: tests/providers/docker/operators/test_docker.py
##########
@@ -244,7 +244,7 @@ def test_execute_xcom_behavior(self):
         xcom_push_result = xcom_push_operator.execute(None)
         no_xcom_push_result = no_xcom_push_operator.execute(None)
 
-        self.assertEqual(xcom_push_result, b'container log')
+        self.assertEqual(xcom_push_result, 'container log')

Review comment:
       _run_image of the DockerOperator returns now a python string, not a byte string (otherwise the json encoding fails)
   but the unit test did check for a byte string




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org