[jira] [Commented] (FLINK-11005) Define flink-sql-client uber-jar dependencies via artifactSet

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-11005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16699100#comment-16699100 ] 

ASF GitHub Bot commented on FLINK-11005:
----------------------------------------

tillrohrmann opened a new pull request #7176: [FLINK-11005] Define flink-sql-client uber-jar dependencies via artifactSet
URL: https://github.com/apache/flink/pull/7176
 
 
   ## What is the purpose of the change
   
   Instead of including every dependency and then limiting the set of included
   files via a filter condition of the maven-shade-pluging, this commit defines
   an artifact set of included dependencies. That way we will properly include
   all files belonging to the listed dependencies (e.g. also the NOTICE file).
   
   
   ## Verifying this change
   
   - Tested manually
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Define flink-sql-client uber-jar dependencies via artifactSet
> -------------------------------------------------------------
>
>                 Key: FLINK-11005
>                 URL: https://issues.apache.org/jira/browse/FLINK-11005
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>    Affects Versions: 1.7.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> The module {{flink-sql-client}} defines the content of its uber jar via filtering files from the set of all dependencies. I think this is not ideal because it misses for example the {{NOTICE}} files from down stream dependencies. 
> A solution could be to define an {{<artifactSet><includes><include></include></includes></artifactSet>}} and exclude files via the filter.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)