You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/05/24 09:46:06 UTC

[GitHub] [superset] geido opened a new pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

geido opened a new pull request #14778:
URL: https://github.com/apache/superset/pull/14778


   ### SUMMARY
   Fixes: #14672
   
   The function `postForm` introduced in PR #9345 has the target set to `_blank` by default. This PR specifies `_self` instead. There does not seem to be any obvious issue in doing so. Input from @graceguo-supercat is appreciated as a double check.
   
   ### TESTING INSTRUCTIONS
   1. Open a dashboard
   2. Choose a chart and select "View Chart in Explore"
   3. Make sure the chart Explore page is opened in the same window
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: #14672
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] john-bodley edited a comment on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
john-bodley edited a comment on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-876610637


   Thanks @rusackas for reverting this. In terms of user feedback, for this week's internal Airbnb release we forgot to locally revert the change (as was done in the previous release) and were pinged almost immediately by a user in Slack with the following:
   
   > When clicking View chart in Explore in my Supeset dashboards, it used to open up Explore view in a separate tab, but now it is navigating away from the dashboard in the same tab..
   >
   > **Are others experiencing this same behavior?**  (might be an issue with my browser settings, although I have not changed anything recently)
   >
   > **Is this expected behavior?**  I frequently use this button to explore multiple charts and datasets and it’s rather cumbersome to have to navigate back to the dashboard every time.  And when you navigate back to the dashboard, it does not return to the tab you were on before


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc commented on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-848096209


   /testenv up
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas commented on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-872366981


   @graceguo-supercat @john-bodley @junlincc 
   
   The reason for the change was that users were annoyed by the proliferation of new tabs, when they felt they _weren't_ necessary. 
   
   Rather than reverting the PR, how about one of two means to support either behavior?
   
   1) Make it an actual link so that users can Command-click or right-click the link to choose to open it in a new window?
   2) Add a configuration variable in config.py so that the admin of the installation can override it?
   
   If neither of those work, or take too long, I suppose we can revert it and then carry it forward in a new PR if needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] john-bodley edited a comment on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
john-bodley edited a comment on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-871818221


   Apologies for the late response. @geido @villebro et al. could one provide context as why we want to explore a chart in place as opposed to in a new tab? I think many users prefer opening a chart in a new tab whilst maintaining reference to the dashboard—especially when one wishes to open multiple charts (which isn't possible with this change). Additionally per @villebro's comment the behavior of opening a chart in a new tab is consistent with "Run in SQL Lab" etc.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc commented on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-847265712


   /testenv up


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] geido commented on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
geido commented on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-849792011


   @junlincc I don't see the problem that you are describing but I see a worse problem.
   
   If you open up any dashboard it will always pre-select the same dashboard, independently from the actual dashboard that you have opened. This is not related to this PR as this problem is reproducible on master and in this branch also now that I have merged it with master.
   
   See video.
   
   https://user-images.githubusercontent.com/60598000/119866680-b9fd1c00-bf25-11eb-8980-9057a44541eb.mp4
   
   Please let me know if you can reproduce it, we should file a separate issue.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] graceguo-supercat edited a comment on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-871820229


   I didn't notice this PR till today....Airbnb users preferred to open "View Chart in Explore", because our dashboard is large, many charts, many tabs. A user may open a dashboard, then click a few tabs and nested sub tabs,  and then click View chart. Open the chart in the same window will make user lost their context. **Please revert this PR**.
   
   I would like to know what's the benefit to open chart in the same window?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc removed a comment on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
junlincc removed a comment on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-847265712


   /testenv up


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] amitmiran137 merged pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
amitmiran137 merged pull request #14778:
URL: https://github.com/apache/superset/pull/14778


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] graceguo-supercat edited a comment on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-872541712


   > users were annoyed by the proliferation of new tabs,
   
   Isn't this showing how frequently user needs to _**dig into many charts from a dashboard**_? 
   
   If this is the case,
   - option 1: open chart from same dashboard window, and go back to dashboard, wait it load, and find next chart.
   - option 2: open chart into another window and leave original dashboard open. User can always go back to dashboard without waiting reloading and find the right tab.
   
   To me the option 2 is much easier and intuitive way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] github-actions[bot] commented on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-870397822


   Ephemeral environment shutdown and build artifacts deleted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] john-bodley edited a comment on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
john-bodley edited a comment on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-871818221


   Apologies for the late response. @geido @villebro et al. could one provide context as why we want to explore a chart in place as opposed to in a new tab? I think many users prefer opening a chart in a new tab whilst maintaining reference to the dashboard—especially when one wishes to open multiple charts (which isn't possible now). Additionally per @villebro's comment the behavior of opening a chart in a new tab is consistent with "Run in SQL Lab" etc.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] graceguo-supercat edited a comment on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-871820229


   I didn't notice this PR till today....Airbnb users preferred to open "View Chart in Explore", because our dashboard is large, many charts, many tabs. A user may open a dashboard, then click a few tabs and nested sub tabs,  and then click View chart. Open the chart in the same window will make user lost their context. **Please revert this change**.
   
   I would like to know what's the benefit to open chart in the same window?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-846934702


   # [Codecov](https://codecov.io/gh/apache/superset/pull/14778?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#14778](https://codecov.io/gh/apache/superset/pull/14778?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9de0217) into [master](https://codecov.io/gh/apache/superset/commit/281d637674ff8c75faea99ae5fc84d3ef6576dce?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (281d637) will **increase** coverage by `0.05%`.
   > The diff coverage is `0.00%`.
   
   > :exclamation: Current head 9de0217 differs from pull request most recent head 4dca748. Consider uploading reports for the commit 4dca748 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/14778/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/14778?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #14778      +/-   ##
   ==========================================
   + Coverage   77.57%   77.62%   +0.05%     
   ==========================================
     Files         963      962       -1     
     Lines       49290    49083     -207     
     Branches     6205     6161      -44     
   ==========================================
   - Hits        38235    38103     -132     
   + Misses      10854    10776      -78     
   - Partials      201      204       +3     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `72.42% <0.00%> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14778?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...uperset-frontend/src/explore/exploreUtils/index.js](https://codecov.io/gh/apache/superset/pull/14778/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzL2luZGV4Lmpz) | `66.25% <0.00%> (ø)` | |
   | [...c/visualizations/TimeTable/TimeTableChartPlugin.js](https://codecov.io/gh/apache/superset/pull/14778/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL1RpbWVUYWJsZS9UaW1lVGFibGVDaGFydFBsdWdpbi5qcw==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
   | [...c/views/CRUD/data/database/DatabaseModal/index.tsx](https://codecov.io/gh/apache/superset/pull/14778/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL2luZGV4LnRzeA==) | `63.81% <0.00%> (-12.32%)` | :arrow_down: |
   | [...c/views/CRUD/data/database/DatabaseModal/styles.ts](https://codecov.io/gh/apache/superset/pull/14778/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL3N0eWxlcy50cw==) | `86.84% <0.00%> (-10.53%)` | :arrow_down: |
   | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/superset/pull/14778/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `46.97% <0.00%> (-6.52%)` | :arrow_down: |
   | [.../database/DatabaseModal/DatabaseConnectionForm.tsx](https://codecov.io/gh/apache/superset/pull/14778/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL0RhdGFiYXNlQ29ubmVjdGlvbkZvcm0udHN4) | `50.00% <0.00%> (-4.55%)` | :arrow_down: |
   | [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/14778/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `94.44% <0.00%> (-2.78%)` | :arrow_down: |
   | [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/superset/pull/14778/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `30.43% <0.00%> (-2.00%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/14778/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `67.44% <0.00%> (-1.56%)` | :arrow_down: |
   | [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/superset/pull/14778/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `27.16% <0.00%> (-1.42%)` | :arrow_down: |
   | ... and [54 more](https://codecov.io/gh/apache/superset/pull/14778/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14778?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14778?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [281d637...4dca748](https://codecov.io/gh/apache/superset/pull/14778?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] amitmiran137 merged pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
amitmiran137 merged pull request #14778:
URL: https://github.com/apache/superset/pull/14778


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] graceguo-supercat edited a comment on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-872541712


   > users were annoyed by the proliferation of new tabs,
   
   Isn't this showing how frequently user needs to _**dig into many charts from a dashboard**_? 
   
   If this is the case,
   - option 1: open chart from same dashboard window, and go back to dashboard, wait it load, and find next chart.
   - option 2: open chart into another window and leave original dashboard open. he can always go back to dashboard without waiting reloading and find the right tab.
   
   To me the option 2 is much easier and intuitive way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] github-actions[bot] removed a comment on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-847266306


   @junlincc Ephemeral environment creation failed. Please check the Actions logs for details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-846934702


   # [Codecov](https://codecov.io/gh/apache/superset/pull/14778?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#14778](https://codecov.io/gh/apache/superset/pull/14778?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (169de6d) into [master](https://codecov.io/gh/apache/superset/commit/281d637674ff8c75faea99ae5fc84d3ef6576dce?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (281d637) will **not change** coverage.
   > The diff coverage is `0.00%`.
   
   > :exclamation: Current head 169de6d differs from pull request most recent head 4dca748. Consider uploading reports for the commit 4dca748 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/14778/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/14778?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #14778   +/-   ##
   =======================================
     Coverage   77.57%   77.57%           
   =======================================
     Files         963      963           
     Lines       49290    49290           
     Branches     6205     6205           
   =======================================
     Hits        38235    38235           
     Misses      10854    10854           
     Partials      201      201           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `72.43% <0.00%> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14778?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...uperset-frontend/src/explore/exploreUtils/index.js](https://codecov.io/gh/apache/superset/pull/14778/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzL2luZGV4Lmpz) | `66.25% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14778?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14778?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [281d637...4dca748](https://codecov.io/gh/apache/superset/pull/14778?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] graceguo-supercat commented on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-872541712


   > users were annoyed by the proliferation of new tabs,
   
   Isn't this showing how frequently user needs to _**dig into many charts from a dashboard**_? If this is the case,
   - option 1: open chart from same dashboard window, and go back to dashboard, wait it load, and find next chart.
   - option 2: open chart into another window and leave original dashboard open. he can always go back to dashboard without waiting reloading and find the right tab.
   
   To me the option 2 is much easier and intuitive way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] john-bodley commented on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
john-bodley commented on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-872470779


   @rusackas we think option (2) makes the most sense, though given this is a breaking change (in terms of UX) we sense it is best to revert the PR and in a follow up PR and the configuration option.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] github-actions[bot] commented on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-870397822


   Ephemeral environment shutdown and build artifacts deleted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] john-bodley commented on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
john-bodley commented on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-876610637


   Thanks @rusackas for reverting this. In terms of user feedback, for this week's internal Airbnb release we forgot to locally revert the change (as was done in the previous release) and were pinged almost immediately by a user in Slack with the following:
   
   > When clicking View chart in Explore in my Supeset dashboards, it used to open up Explore view in a separate tab, but now it is navigating away from the dashboard in the same tab..
   >
   > **Are others experiencing this same behavior?**  (might be an issue with my browser settings, although I have not changed anything recently)
   >
   > **Is this expected behavior?**  I frequently use this button to explore multiple charts and datasets and it’s rather cumbersome to have to navigate back to the dashboard every time.  And when you navigate back to the dashboard, it does not return to the tab you were on before (edited) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc commented on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-849004869


   Thanks for the PR. Please see video of Before and After behavior in select of Dashboard->Explore->Dashboard flow 
   
   https://user-images.githubusercontent.com/67837651/119709552-31da2200-be12-11eb-9cf6-f75e93948dc7.mov
   
   Previous behavior. View chart in Explore takes user to Explore, user revise the chart in Explore and can save it back to same dashboard( preselect in the dropdown). i dont think your PR changed the behavior, just wonder why the source dashboard is not preselected anymore. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc commented on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-872546379


   
   
   
   
   > really BAD idea. don't do it.
   
   sure!! 😁 
   but again, the assumption we had is based on feedback from a good number of new Superset users. I can foresee more "disagreements" on changes are coming in the future, to make everyone happy, i suggest to make Superset more configurable and general, instead of building it around any specific organizations. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] graceguo-supercat commented on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-871820229


   I didn't notice this PR till today....Airbnb users preferred to open "View Chart in Explore", because our dashboard is large, many charts, many tabs, user may click a few tabs and then click View chart. Open the chart in the same window will make user lost their context. Please revert this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] commented on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-846934702


   # [Codecov](https://codecov.io/gh/apache/superset/pull/14778?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#14778](https://codecov.io/gh/apache/superset/pull/14778?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9de0217) into [master](https://codecov.io/gh/apache/superset/commit/d03c608ce13ab4595263c7deac268cf38dac1947?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d03c608) will **not change** coverage.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/14778/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/14778?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #14778   +/-   ##
   =======================================
     Coverage   77.62%   77.62%           
   =======================================
     Files         962      962           
     Lines       49083    49083           
     Branches     6161     6161           
   =======================================
     Hits        38103    38103           
     Misses      10776    10776           
     Partials      204      204           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `72.42% <0.00%> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14778?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...uperset-frontend/src/explore/exploreUtils/index.js](https://codecov.io/gh/apache/superset/pull/14778/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzL2luZGV4Lmpz) | `66.25% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14778?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14778?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d03c608...9de0217](https://codecov.io/gh/apache/superset/pull/14778?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] graceguo-supercat commented on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-872543472


   > change "View chart in Explore" to "Edit chart in Explore"
   
   really BAD idea. don't do it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc commented on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-872541540


   hi @john-bodley @michellethomas i saw that you have reverted this change from locally. thanks for the feedback 🙏
   
   We assume that the reason why a user click "View chart in Explore" is to tweak a specific chart, because all of the "view only" functionalities, including 1) view query 2)view chart details by hovering 3) maximize chart 4) filtering chart can all be done straightly from Dashboard. 
   Under this assumption, "opening Explore from the same window -> making changes in Explore -> saving chart and going back to the same dashboard -> seeing changes appear on original or a new dashboard" seem to be a better/ more simplified workflow than leaving multiple tabs that show different versions of the same dashboard hanging. One quick enhancement to eliminate confusion is to change "View chart in Explore" to "Edit chart in Explore" 
   
   I apologize if this assumption doesn't make sense to your users and the inconvenience we introduced by the change. 
   As more and more users adopt Superset globally, accommodating to all users from different organizations became harder and harder, which means changes are inevitable. 
   But I'm not sure if this this change is considered as a "breaking change"
   according to a passed SIP [SIP-57] Proposal for Semantic Versioning, the definition of UI/UX changes is as follow 
   - Changes that removes an existing functionality, such as a chart type or ability to select favorites. 
   (Inconsequential visual changes or small functional changes such as removing a tooltip or the removing the ability to color a label aren't considered breaking changes.)
   - Changes that break an existing workflow without providing a clear alternative or require user intervention for the alternative to be applied.
   
   User may take a while to adapt to the optimized new flow, but the original functionality - opening Explore was not removed by this PR. I would suggest to go with proposed solution 2 without reverting from the main repo. 🙏


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] graceguo-supercat commented on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-872562411


   Totally agree  **make Superset more configurable and general**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] graceguo-supercat edited a comment on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-871820229


   I didn't notice this PR till today....Airbnb users preferred to open "View Chart in Explore", because our dashboard is large, many charts, many tabs. A user may open a dashboard, then click a few tabs and nested sub tabs,  and then click View chart. Open the chart in the same window will make user lost their context. Please revert this PR.
   
   I would like to know what's the benefit to open chart in the same window?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] john-bodley commented on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
john-bodley commented on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-871818221


   @geido @villebro et al. could one provide context as why we want to explore a chart in place as opposed to in a new tab? I think many users prefer opening a chart in a new tab whilst maintaining reference to the dashboard—especially when one wishes to open multiple charts (which isn't possible now). Additionally per @villebro's comment the behavior of opening a chart in a new tab is consistent with "Run in SQL Lab" etc.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] graceguo-supercat edited a comment on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-871820229


   I didn't notice this PR till today....Airbnb users preferred to open "View Chart in Explore", because our dashboard is large, many charts, many tabs. A user may open a dashboard, then click a few tabs and nested sub tabs,  and then click View chart. Open the chart in the same window will make user lost their context. Please revert this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] geido edited a comment on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
geido edited a comment on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-849792011


   @junlincc I don't see the problem that you are describing but I see a worse problem.
   
   If you open up any dashboard it will always pre-select the same dashboard, independently from the actual dashboard that you have opened. This is not related to this PR as this problem is reproducible on master and in this branch also now that I have merged it with master.
   
   See video.
   
   https://user-images.githubusercontent.com/60598000/119867313-6b9c4d00-bf26-11eb-96d5-9db751c9d576.mp4
   
   
   Please let me know if you can reproduce it, we should file a separate issue.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] github-actions[bot] commented on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-848098746


   @junlincc Ephemeral environment spinning up at http://34.218.44.244:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] github-actions[bot] commented on pull request #14778: fix(dashboard): Open "View Chart in Explore" in the same window

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14778:
URL: https://github.com/apache/superset/pull/14778#issuecomment-847266306


   @junlincc Ephemeral environment creation failed. Please check the Actions logs for details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org