You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "John Casey (JIRA)" <ji...@codehaus.org> on 2008/07/31 17:40:26 UTC
[jira] Created: (WAGON-234) deprecated proxyInfo parameter for
Wagon.connect(..) doesn't work in 1.0-beta-4
deprecated proxyInfo parameter for Wagon.connect(..) doesn't work in 1.0-beta-4
-------------------------------------------------------------------------------
Key: WAGON-234
URL: http://jira.codehaus.org/browse/WAGON-234
Project: Maven Wagon
Issue Type: Bug
Components: wagon-provider-api
Affects Versions: 1.0-beta-4
Reporter: John Casey
Fix For: 1.0-beta-5
proxyInfo parameter passed into some connect(..) methods is set on the AbstractWagon instance, but is never used. This will probably cause problems for users of older versions of wagon, as it did with DefaultWagonManager in maven-artifact-manager 2.0.10-RC4 snapshot, until I traced it back and learned that I had to provide a ProxyInfoProvider instance instead to get proxies working.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (WAGON-234) deprecated proxyInfo parameter for
Wagon.connect(..) doesn't work in 1.0-beta-4
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/WAGON-234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter closed WAGON-234.
------------------------------
Assignee: Brett Porter
Resolution: Cannot Reproduce
Fix Version/s: (was: 1.0-beta-5)
I was able to upgrade 2.0.11 to wagon-provider 1.0-beta-5-SNAPSHOT without changing the signatures and it all worked fine...
> deprecated proxyInfo parameter for Wagon.connect(..) doesn't work in 1.0-beta-4
> -------------------------------------------------------------------------------
>
> Key: WAGON-234
> URL: http://jira.codehaus.org/browse/WAGON-234
> Project: Maven Wagon
> Issue Type: Bug
> Components: wagon-provider-api
> Affects Versions: 1.0-beta-4
> Reporter: John Casey
> Assignee: Brett Porter
>
> proxyInfo parameter passed into some connect(..) methods is set on the AbstractWagon instance, but is never used. This will probably cause problems for users of older versions of wagon, as it did with DefaultWagonManager in maven-artifact-manager 2.0.10-RC4 snapshot, until I traced it back and learned that I had to provide a ProxyInfoProvider instance instead to get proxies working.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WAGON-234) deprecated proxyInfo parameter for
Wagon.connect(..) doesn't work in 1.0-beta-4
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/WAGON-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=143792#action_143792 ]
John Casey commented on WAGON-234:
----------------------------------
When I rolled the beta-4 version of wagon back into the 2.0.10-RC build, DefaultWagonManager was still using connect(.., ProxyInfo) instead of the ProxyInfoProvider method. The result was the IT for MNG-3599 would not pass. When I looked into the code (maven-artifact-manager and wagon-provider-api), I found that, yes, the proxyInfo variable, which is deprecated, was set. However, I had all of the wagon projects loaded and open in my Eclipse workspace, and a reference search for that field didn't turn up anything at all except for that assignment. I can't see that this deprecated field is used anywhere at all.
If I'm incorrect, that's great, but the IT magically started working when I replaced the connect(..) calls in DefaultWagonManager with the version that passed in ProxyInfoProvider instances. No other changes to the IT at all.
> deprecated proxyInfo parameter for Wagon.connect(..) doesn't work in 1.0-beta-4
> -------------------------------------------------------------------------------
>
> Key: WAGON-234
> URL: http://jira.codehaus.org/browse/WAGON-234
> Project: Maven Wagon
> Issue Type: Bug
> Components: wagon-provider-api
> Affects Versions: 1.0-beta-4
> Reporter: John Casey
> Fix For: 1.0-beta-5
>
>
> proxyInfo parameter passed into some connect(..) methods is set on the AbstractWagon instance, but is never used. This will probably cause problems for users of older versions of wagon, as it did with DefaultWagonManager in maven-artifact-manager 2.0.10-RC4 snapshot, until I traced it back and learned that I had to provide a ProxyInfoProvider instance instead to get proxies working.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WAGON-234) deprecated proxyInfo parameter for
Wagon.connect(..) doesn't work in 1.0-beta-4
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/WAGON-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=143782#action_143782 ]
Brett Porter commented on WAGON-234:
------------------------------------
can you elaborate on the circumstances that caused this?
it is set, and is intended to be used as a fallback, but perhaps one particular sequence doesn't do this
> deprecated proxyInfo parameter for Wagon.connect(..) doesn't work in 1.0-beta-4
> -------------------------------------------------------------------------------
>
> Key: WAGON-234
> URL: http://jira.codehaus.org/browse/WAGON-234
> Project: Maven Wagon
> Issue Type: Bug
> Components: wagon-provider-api
> Affects Versions: 1.0-beta-4
> Reporter: John Casey
> Fix For: 1.0-beta-5
>
>
> proxyInfo parameter passed into some connect(..) methods is set on the AbstractWagon instance, but is never used. This will probably cause problems for users of older versions of wagon, as it did with DefaultWagonManager in maven-artifact-manager 2.0.10-RC4 snapshot, until I traced it back and learned that I had to provide a ProxyInfoProvider instance instead to get proxies working.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WAGON-234) deprecated proxyInfo parameter for
Wagon.connect(..) doesn't work in 1.0-beta-4
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/WAGON-234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Casey updated WAGON-234:
-----------------------------
Fix Version/s: 1.0-beta-5
> deprecated proxyInfo parameter for Wagon.connect(..) doesn't work in 1.0-beta-4
> -------------------------------------------------------------------------------
>
> Key: WAGON-234
> URL: http://jira.codehaus.org/browse/WAGON-234
> Project: Maven Wagon
> Issue Type: Bug
> Components: wagon-provider-api
> Affects Versions: 1.0-beta-4
> Reporter: John Casey
> Fix For: 1.0-beta-5
>
>
> proxyInfo parameter passed into some connect(..) methods is set on the AbstractWagon instance, but is never used. This will probably cause problems for users of older versions of wagon, as it did with DefaultWagonManager in maven-artifact-manager 2.0.10-RC4 snapshot, until I traced it back and learned that I had to provide a ProxyInfoProvider instance instead to get proxies working.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WAGON-234) deprecated proxyInfo parameter for
Wagon.connect(..) doesn't work in 1.0-beta-4
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/WAGON-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=143794#action_143794 ]
Brett Porter commented on WAGON-234:
------------------------------------
I'll take a look - Wagon itself now uses the provider, and a default one using the proxyInfo is constructed in that constructor. The old field is there for anyone using it since it was a protected variable.
I'm quite sure the ITs worked with the old constructor - but good that it is working now.
> deprecated proxyInfo parameter for Wagon.connect(..) doesn't work in 1.0-beta-4
> -------------------------------------------------------------------------------
>
> Key: WAGON-234
> URL: http://jira.codehaus.org/browse/WAGON-234
> Project: Maven Wagon
> Issue Type: Bug
> Components: wagon-provider-api
> Affects Versions: 1.0-beta-4
> Reporter: John Casey
> Fix For: 1.0-beta-5
>
>
> proxyInfo parameter passed into some connect(..) methods is set on the AbstractWagon instance, but is never used. This will probably cause problems for users of older versions of wagon, as it did with DefaultWagonManager in maven-artifact-manager 2.0.10-RC4 snapshot, until I traced it back and learned that I had to provide a ProxyInfoProvider instance instead to get proxies working.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira