[GitHub] [samza] sborya commented on a change in pull request #1213: SAMZA-2305: Stream processor should ensure previous container is stopped during a rebalance

[GitBox <gi...@apache.org>]

sborya commented on a change in pull request #1213: SAMZA-2305: Stream processor should ensure previous container is stopped during a rebalance
URL: https://github.com/apache/samza/pull/1213#discussion_r347580067
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/storage/StorageRecovery.java
 ##########
 @@ -117,7 +117,12 @@ public void run() {
 
     systemAdmins.start();
     this.containerStorageManagers.forEach((containerName, containerStorageManager) -> {
-        containerStorageManager.start();
+        try {
+          containerStorageManager.start();
+        } catch (InterruptedException e) {
+          LOG.warn("Received an interrupt during store restoration for container {}."
 
 Review comment:
   Please add a comment why we 'ignore' the exception.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services