[GitHub] [inlong] gong commented on a diff in pull request #6508: [INLONG-6507][Sort] Convert date to timestamp in oracle connector

[GitBox <gi...@apache.org>]

gong commented on code in PR #6508:
URL: https://github.com/apache/inlong/pull/6508#discussion_r1020675510


##########
inlong-sort/sort-connectors/oracle-cdc/src/main/java/org/apache/inlong/sort/cdc/oracle/debezium/table/RowDataDebeziumDeserializeSchema.java:
##########
@@ -760,33 +760,18 @@ public Object convert(Object dbzObj, Schema schema, TableChange tableSchema) thr
      * @return the extracted data with schema
      */
     private Object getValueWithSchema(Object fieldValue, String schemaName) {
-        if (fieldValue == null) {
-            return null;
-        }
-        // Remove shaded pattern prefix of package name
-        schemaName = schemaName.replace(shadedPatternPrefix, "");

Review Comment:
   ```java
   private static final String shadedPatternPrefix = "org.apache.inlong.sort.cdc.oracle.shaded.";
   ```
   It is not used.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org