[jira] [Commented] (MAPREDUCE-5747) Potential null pointer deference in HsTasksBlock#render()

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933541#comment-14933541 ] 

Hadoop QA commented on MAPREDUCE-5747:
--------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  18m 19s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | javac |   8m 50s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |  10m 48s | There were no new javadoc warning messages. |
| {color:green}+1{color} | release audit |   0m 24s | The applied patch does not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle |   0m 27s | The applied patch generated  1 new checkstyle issues (total was 10, now 10). |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace. |
| {color:green}+1{color} | install |   1m 35s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 39s | The patch built with eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   0m 56s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | mapreduce tests |   6m  5s | Tests passed in hadoop-mapreduce-client-hs. |
| | |  48m  9s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12764034/MAPREDUCE-5747-2.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 892ade6 |
| checkstyle |  https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6025/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-hs.txt |
| hadoop-mapreduce-client-hs test log | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6025/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt |
| Test Results | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6025/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6025/console |


This message was automatically generated.

> Potential null pointer deference in HsTasksBlock#render()
> ---------------------------------------------------------
>
>                 Key: MAPREDUCE-5747
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5747
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>              Labels: BB2015-05-TBR, newbie, patch
>         Attachments: MAPREDUCE-5747-1.patch, MAPREDUCE-5747-2.patch
>
>
> At line 140:
> {code}
>         } else {
>           ta = new TaskAttemptInfo(successful, type, false);
> {code}
> There is no check for type against null.
> TaskAttemptInfo ctor deferences type:
> {code}
>   public TaskAttemptInfo(TaskAttempt ta, TaskType type, Boolean isRunning) {
>     final TaskAttemptReport report = ta.getReport();
>     this.type = type.toString();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)