[GitHub] [incubator-pekko-connectors-kafka] He-Pin commented on a diff in pull request #65: Apply compat changes from latest Pekko

["He-Pin (via GitHub)" <gi...@apache.org>]

He-Pin commented on code in PR #65:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/65#discussion_r1189982868


##########
core/src/main/scala/org/apache/pekko/kafka/ProducerSettings.scala:
##########
@@ -24,13 +24,13 @@ import com.typesafe.config.Config
 import org.apache.kafka.clients.producer.{ KafkaProducer, Producer, ProducerConfig }
 import org.apache.kafka.common.serialization.Serializer
 
-import scala.compat.java8.OptionConverters._
 import scala.concurrent.duration._
 import pekko.util.ccompat.JavaConverters._
+import pekko.util.FutureConverters._
 import pekko.util.JavaDurationConverters._
+import pekko.util.OptionConverters._

Review Comment:
   How about run a `sbt sortImports`?



##########
core/src/main/scala/org/apache/pekko/kafka/ProducerSettings.scala:
##########
@@ -24,13 +24,13 @@ import com.typesafe.config.Config
 import org.apache.kafka.clients.producer.{ KafkaProducer, Producer, ProducerConfig }
 import org.apache.kafka.common.serialization.Serializer
 
-import scala.compat.java8.OptionConverters._
 import scala.concurrent.duration._
 import pekko.util.ccompat.JavaConverters._
+import pekko.util.FutureConverters._
 import pekko.util.JavaDurationConverters._
+import pekko.util.OptionConverters._

Review Comment:
   How about running a `sbt sortImports`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org