You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/29 14:06:31 UTC

[GitHub] [flink] zentol opened a new pull request #14810: [FLINK-9844][client] PackagedProgram#close() closes ClassLoader 

zentol opened a new pull request #14810:
URL: https://github.com/apache/flink/pull/14810


   Based on https://github.com/apache/flink/pull/14777.
   
   The `PackagedProgram` now uses a `URLClassLoader`, giving us access to the close() method with which we can close the jar files that the class loader uses.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14810: [FLINK-9844][client] PackagedProgram#close() closes ClassLoader

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14810:
URL: https://github.com/apache/flink/pull/14810#issuecomment-769826863


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 0dee1f6c07a80da9abc5690b2a87442dc1725fd9 (Fri May 28 08:16:38 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol merged pull request #14810: [FLINK-9844][client] PackagedProgram#close() closes ClassLoader

Posted by GitBox <gi...@apache.org>.
zentol merged pull request #14810:
URL: https://github.com/apache/flink/pull/14810


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14810: [FLINK-9844][client] PackagedProgram#close() closes ClassLoader

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14810:
URL: https://github.com/apache/flink/pull/14810#issuecomment-769830895


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d666d443ee90e4a5ce6eccf1874f498b9f2744a8",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12663",
       "triggerID" : "d666d443ee90e4a5ce6eccf1874f498b9f2744a8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d666d443ee90e4a5ce6eccf1874f498b9f2744a8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12663) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14810: [FLINK-9844][client] PackagedProgram#close() closes ClassLoader

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14810:
URL: https://github.com/apache/flink/pull/14810#issuecomment-769826863


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit d666d443ee90e4a5ce6eccf1874f498b9f2744a8 (Fri Jan 29 14:09:42 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14810: [FLINK-9844][client] PackagedProgram#close() closes ClassLoader

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14810:
URL: https://github.com/apache/flink/pull/14810#issuecomment-769830895


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d666d443ee90e4a5ce6eccf1874f498b9f2744a8",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12663",
       "triggerID" : "d666d443ee90e4a5ce6eccf1874f498b9f2744a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0dee1f6c07a80da9abc5690b2a87442dc1725fd9",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12679",
       "triggerID" : "0dee1f6c07a80da9abc5690b2a87442dc1725fd9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d666d443ee90e4a5ce6eccf1874f498b9f2744a8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12663) 
   * 0dee1f6c07a80da9abc5690b2a87442dc1725fd9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12679) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14810: [FLINK-9844][client] PackagedProgram#close() closes ClassLoader

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14810:
URL: https://github.com/apache/flink/pull/14810#issuecomment-769830895


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d666d443ee90e4a5ce6eccf1874f498b9f2744a8",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12663",
       "triggerID" : "d666d443ee90e4a5ce6eccf1874f498b9f2744a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0dee1f6c07a80da9abc5690b2a87442dc1725fd9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0dee1f6c07a80da9abc5690b2a87442dc1725fd9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d666d443ee90e4a5ce6eccf1874f498b9f2744a8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12663) 
   * 0dee1f6c07a80da9abc5690b2a87442dc1725fd9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14810: [FLINK-9844][client] PackagedProgram#close() closes ClassLoader

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14810:
URL: https://github.com/apache/flink/pull/14810#issuecomment-769830895


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d666d443ee90e4a5ce6eccf1874f498b9f2744a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12663",
       "triggerID" : "d666d443ee90e4a5ce6eccf1874f498b9f2744a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0dee1f6c07a80da9abc5690b2a87442dc1725fd9",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12679",
       "triggerID" : "0dee1f6c07a80da9abc5690b2a87442dc1725fd9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0dee1f6c07a80da9abc5690b2a87442dc1725fd9 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12679) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14810: [FLINK-9844][client] PackagedProgram#close() closes ClassLoader

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14810:
URL: https://github.com/apache/flink/pull/14810#issuecomment-769830895


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d666d443ee90e4a5ce6eccf1874f498b9f2744a8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d666d443ee90e4a5ce6eccf1874f498b9f2744a8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d666d443ee90e4a5ce6eccf1874f498b9f2744a8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org