You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/06/15 14:47:27 UTC
[GitHub] [hudi] loukey-lj opened a new pull request, #5877: [HUDI-4260] Change KEYGEN_CLASS_NAME without default value
loukey-lj opened a new pull request, #5877:
URL: https://github.com/apache/hudi/pull/5877
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5877: [HUDI-4260] Change KEYGEN_CLASS_NAME without default value
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5877:
URL: https://github.com/apache/hudi/pull/5877#issuecomment-1160565348
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dff3ee262c66d90c4afe0b23fa2fbb4563315af1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9320",
"triggerID" : "dff3ee262c66d90c4afe0b23fa2fbb4563315af1",
"triggerType" : "PUSH"
}, {
"hash" : "2e33dca6f6a65d190f60db20737303b549c8b3b3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2e33dca6f6a65d190f60db20737303b549c8b3b3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dff3ee262c66d90c4afe0b23fa2fbb4563315af1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9320)
* 2e33dca6f6a65d190f60db20737303b549c8b3b3 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5877: [HUDI-4260] Change KEYGEN_CLASS_NAME without default value
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5877:
URL: https://github.com/apache/hudi/pull/5877#issuecomment-1161987302
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dff3ee262c66d90c4afe0b23fa2fbb4563315af1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9320",
"triggerID" : "dff3ee262c66d90c4afe0b23fa2fbb4563315af1",
"triggerType" : "PUSH"
}, {
"hash" : "2e33dca6f6a65d190f60db20737303b549c8b3b3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9402",
"triggerID" : "2e33dca6f6a65d190f60db20737303b549c8b3b3",
"triggerType" : "PUSH"
}, {
"hash" : "a6e8a3375933b7b0d65553fd09b2299906d8eff0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a6e8a3375933b7b0d65553fd09b2299906d8eff0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e33dca6f6a65d190f60db20737303b549c8b3b3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9402)
* a6e8a3375933b7b0d65553fd09b2299906d8eff0 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5877: [HUDI-4260] Change KEYGEN_CLASS_NAME without default value
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5877:
URL: https://github.com/apache/hudi/pull/5877#issuecomment-1156606104
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dff3ee262c66d90c4afe0b23fa2fbb4563315af1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9320",
"triggerID" : "dff3ee262c66d90c4afe0b23fa2fbb4563315af1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dff3ee262c66d90c4afe0b23fa2fbb4563315af1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9320)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #5877: [HUDI-4260] Change KEYGEN_CLASS_NAME without default value
Posted by GitBox <gi...@apache.org>.
danny0405 commented on PR #5877:
URL: https://github.com/apache/hudi/pull/5877#issuecomment-1157175848
Thanks, i would suggest to keep it in order to be null-safe, or we should check all the code paths that use the option for null checking. For example, such validation now throws NPE:
`conf.getString(FlinkOptions.KEYGEN_CLASS_NAME).equals(TimestampBasedAvroKeyGenerator.class.getName()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #5877: [HUDI-4260] Change KEYGEN_CLASS_NAME without default value
Posted by GitBox <gi...@apache.org>.
danny0405 merged PR #5877:
URL: https://github.com/apache/hudi/pull/5877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5877: [HUDI-4260] Change KEYGEN_CLASS_NAME without default value
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5877:
URL: https://github.com/apache/hudi/pull/5877#issuecomment-1160572491
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dff3ee262c66d90c4afe0b23fa2fbb4563315af1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9320",
"triggerID" : "dff3ee262c66d90c4afe0b23fa2fbb4563315af1",
"triggerType" : "PUSH"
}, {
"hash" : "2e33dca6f6a65d190f60db20737303b549c8b3b3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9402",
"triggerID" : "2e33dca6f6a65d190f60db20737303b549c8b3b3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dff3ee262c66d90c4afe0b23fa2fbb4563315af1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9320)
* 2e33dca6f6a65d190f60db20737303b549c8b3b3 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9402)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5877: [HUDI-4260] Change KEYGEN_CLASS_NAME without default value
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5877:
URL: https://github.com/apache/hudi/pull/5877#issuecomment-1162033615
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dff3ee262c66d90c4afe0b23fa2fbb4563315af1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9320",
"triggerID" : "dff3ee262c66d90c4afe0b23fa2fbb4563315af1",
"triggerType" : "PUSH"
}, {
"hash" : "2e33dca6f6a65d190f60db20737303b549c8b3b3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9402",
"triggerID" : "2e33dca6f6a65d190f60db20737303b549c8b3b3",
"triggerType" : "PUSH"
}, {
"hash" : "a6e8a3375933b7b0d65553fd09b2299906d8eff0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9440",
"triggerID" : "a6e8a3375933b7b0d65553fd09b2299906d8eff0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e33dca6f6a65d190f60db20737303b549c8b3b3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9402)
* a6e8a3375933b7b0d65553fd09b2299906d8eff0 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9440)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5877: [HUDI-4260] Change KEYGEN_CLASS_NAME without default value
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5877:
URL: https://github.com/apache/hudi/pull/5877#issuecomment-1162161492
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dff3ee262c66d90c4afe0b23fa2fbb4563315af1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9320",
"triggerID" : "dff3ee262c66d90c4afe0b23fa2fbb4563315af1",
"triggerType" : "PUSH"
}, {
"hash" : "2e33dca6f6a65d190f60db20737303b549c8b3b3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9402",
"triggerID" : "2e33dca6f6a65d190f60db20737303b549c8b3b3",
"triggerType" : "PUSH"
}, {
"hash" : "a6e8a3375933b7b0d65553fd09b2299906d8eff0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9440",
"triggerID" : "a6e8a3375933b7b0d65553fd09b2299906d8eff0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a6e8a3375933b7b0d65553fd09b2299906d8eff0 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9440)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5877: [HUDI-4260] Change KEYGEN_CLASS_NAME without default value
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5877:
URL: https://github.com/apache/hudi/pull/5877#issuecomment-1156601004
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dff3ee262c66d90c4afe0b23fa2fbb4563315af1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dff3ee262c66d90c4afe0b23fa2fbb4563315af1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dff3ee262c66d90c4afe0b23fa2fbb4563315af1 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5877: [HUDI-4260] Change KEYGEN_CLASS_NAME without default value
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5877:
URL: https://github.com/apache/hudi/pull/5877#issuecomment-1156690226
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dff3ee262c66d90c4afe0b23fa2fbb4563315af1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9320",
"triggerID" : "dff3ee262c66d90c4afe0b23fa2fbb4563315af1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dff3ee262c66d90c4afe0b23fa2fbb4563315af1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9320)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5877: [HUDI-4260] Change KEYGEN_CLASS_NAME without default value
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5877:
URL: https://github.com/apache/hudi/pull/5877#issuecomment-1160675071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dff3ee262c66d90c4afe0b23fa2fbb4563315af1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9320",
"triggerID" : "dff3ee262c66d90c4afe0b23fa2fbb4563315af1",
"triggerType" : "PUSH"
}, {
"hash" : "2e33dca6f6a65d190f60db20737303b549c8b3b3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9402",
"triggerID" : "2e33dca6f6a65d190f60db20737303b549c8b3b3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e33dca6f6a65d190f60db20737303b549c8b3b3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9402)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] loukey-lj commented on pull request #5877: [HUDI-4260] Change KEYGEN_CLASS_NAME without default value
Posted by GitBox <gi...@apache.org>.
loukey-lj commented on PR #5877:
URL: https://github.com/apache/hudi/pull/5877#issuecomment-1162546373
> Thanks, i would suggest to keep it as it is in order to be null-safe, or we should check all the code paths that use the option for null checking. For example, such validation now throws NPE: `conf.getString(FlinkOptions.KEYGEN_CLASS_NAME).equals(TimestampBasedAvroKeyGenerator.class.getName()`
Done. Thanks for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org