You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/13 21:05:35 UTC
[GitHub] [flink] damjad opened a new pull request #12136: [FLINK-17578][flink-streaming] Union of 2 SideOutputs behaviour incorrect
damjad opened a new pull request #12136:
URL: https://github.com/apache/flink/pull/12136
## What is the purpose of the change
This pull request fixes the behavior: when we take the union of two side outputs of the same operator. Flink was repeating the data from one twice and it was not printing the other one.
## Brief change log
* Added outputTag in hashcode and equals of StreamEdge.
## Verifying this change
This change added tests and can be verified as follows:
*SideOutputITCase*
- Added tests to check the various cases that can occur while taking union of the output of two side outputs.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12136: [FLINK-17578][flink-streaming] Union of 2 SideOutputs behaviour incorrect
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12136:
URL: https://github.com/apache/flink/pull/12136#issuecomment-628258215
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "411561c7763474d77bf4db9c52b07613395b1384",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1215",
"triggerID" : "411561c7763474d77bf4db9c52b07613395b1384",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 411561c7763474d77bf4db9c52b07613395b1384 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1215)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12136: [FLINK-17578][flink-streaming] Union of 2 SideOutputs behaviour incorrect
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12136:
URL: https://github.com/apache/flink/pull/12136#issuecomment-628246878
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 411561c7763474d77bf4db9c52b07613395b1384 (Wed May 13 21:08:56 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12136: [FLINK-17578][flink-streaming] Union of 2 SideOutputs behaviour incorrect
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12136:
URL: https://github.com/apache/flink/pull/12136#issuecomment-628258215
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "411561c7763474d77bf4db9c52b07613395b1384",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1215",
"triggerID" : "411561c7763474d77bf4db9c52b07613395b1384",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 411561c7763474d77bf4db9c52b07613395b1384 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1215)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] damjad commented on pull request #12136: [FLINK-17578][flink-streaming] Union of 2 SideOutputs behaviour incorrect
Posted by GitBox <gi...@apache.org>.
damjad commented on pull request #12136:
URL: https://github.com/apache/flink/pull/12136#issuecomment-628260486
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12136: [FLINK-17578][flink-streaming] Union of 2 SideOutputs behaviour incorrect
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12136:
URL: https://github.com/apache/flink/pull/12136#issuecomment-628258215
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "411561c7763474d77bf4db9c52b07613395b1384",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "411561c7763474d77bf4db9c52b07613395b1384",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 411561c7763474d77bf4db9c52b07613395b1384 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12136: [FLINK-17578][flink-streaming] Union of 2 SideOutputs behaviour incorrect
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12136:
URL: https://github.com/apache/flink/pull/12136#issuecomment-628258215
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "411561c7763474d77bf4db9c52b07613395b1384",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1215",
"triggerID" : "411561c7763474d77bf4db9c52b07613395b1384",
"triggerType" : "PUSH"
}, {
"hash" : "90017951828d3603677f1ce71b3f989385e4c714",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "90017951828d3603677f1ce71b3f989385e4c714",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 411561c7763474d77bf4db9c52b07613395b1384 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1215)
* 90017951828d3603677f1ce71b3f989385e4c714 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on a change in pull request #12136: [FLINK-17578][flink-streaming] Union of 2 SideOutputs behaviour incorrect
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #12136:
URL: https://github.com/apache/flink/pull/12136#discussion_r424967911
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamEdge.java
##########
@@ -137,7 +137,12 @@ public void setPartitioner(StreamPartitioner<?> partitioner) {
@Override
public int hashCode() {
- return edgeId.hashCode();
+ int result = 17;
Review comment:
This could use `Objects.hash()`
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamEdge.java
##########
@@ -150,8 +155,9 @@ public boolean equals(Object o) {
}
StreamEdge that = (StreamEdge) o;
-
- return edgeId.equals(that.edgeId);
+ return edgeId != null && edgeId.equals(that.edgeId) &&
Review comment:
This could use `Objects.equals()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] damjad commented on a change in pull request #12136: [FLINK-17578][flink-streaming] Union of 2 SideOutputs behaviour incorrect
Posted by GitBox <gi...@apache.org>.
damjad commented on a change in pull request #12136:
URL: https://github.com/apache/flink/pull/12136#discussion_r425085499
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamEdge.java
##########
@@ -150,8 +155,9 @@ public boolean equals(Object o) {
}
StreamEdge that = (StreamEdge) o;
-
- return edgeId.equals(that.edgeId);
+ return edgeId != null && edgeId.equals(that.edgeId) &&
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12136: [FLINK-17578][flink-streaming] Union of 2 SideOutputs behaviour incorrect
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12136:
URL: https://github.com/apache/flink/pull/12136#issuecomment-628258215
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "411561c7763474d77bf4db9c52b07613395b1384",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1215",
"triggerID" : "411561c7763474d77bf4db9c52b07613395b1384",
"triggerType" : "PUSH"
}, {
"hash" : "90017951828d3603677f1ce71b3f989385e4c714",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1291",
"triggerID" : "90017951828d3603677f1ce71b3f989385e4c714",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 411561c7763474d77bf4db9c52b07613395b1384 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1215)
* 90017951828d3603677f1ce71b3f989385e4c714 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1291)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #12136: [FLINK-17578][flink-streaming] Union of 2 SideOutputs behaviour incorrect
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12136:
URL: https://github.com/apache/flink/pull/12136#issuecomment-628669248
Thanks a lot for this fix! 👌 I merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] damjad commented on pull request #12136: [FLINK-17578][flink-streaming] Union of 2 SideOutputs behaviour incorrect
Posted by GitBox <gi...@apache.org>.
damjad commented on pull request #12136:
URL: https://github.com/apache/flink/pull/12136#issuecomment-628591004
@ajoscha Added the cases in `SideOutputITCase.java`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha closed pull request #12136: [FLINK-17578][flink-streaming] Union of 2 SideOutputs behaviour incorrect
Posted by GitBox <gi...@apache.org>.
aljoscha closed pull request #12136:
URL: https://github.com/apache/flink/pull/12136
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] damjad commented on a change in pull request #12136: [FLINK-17578][flink-streaming] Union of 2 SideOutputs behaviour incorrect
Posted by GitBox <gi...@apache.org>.
damjad commented on a change in pull request #12136:
URL: https://github.com/apache/flink/pull/12136#discussion_r425085400
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamEdge.java
##########
@@ -137,7 +137,12 @@ public void setPartitioner(StreamPartitioner<?> partitioner) {
@Override
public int hashCode() {
- return edgeId.hashCode();
+ int result = 17;
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org