[GitHub] [airflow] turbaszek commented on a change in pull request #10115: Add Legacy command displaying new CLI counterparts

[GitBox <gi...@apache.org>]

turbaszek commented on a change in pull request #10115:
URL: https://github.com/apache/airflow/pull/10115#discussion_r464057031



##########
File path: airflow/cli/commands/legacy_commands.py
##########
@@ -0,0 +1,118 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from argparse import ArgumentError
+
+
+def check_value(action, value):  # pylint: disable=too-many-branches
+    # pylint: disable=too-many-statements
+    """ Checks command value and raise error if value is in removed command"""
+
+    # celery group
+    if value == "worker":
+        message = "worker command has been removed, please use `airflow celery worker`"
+        raise ArgumentError(action, message)

Review comment:
       How about
   ```python
   def check_value(action, value):
       cmd_map = {
           "worker": "celery worker",  # old: new
           ...
       }
       try:
           msg = "{} command, has been removed, please use `airflow {}`.format(value, cmd_map[value]
           raise ArgumentError(action, msg)
       excep KeyError:
          raise ArgumentError(action, "Command {} not found".format(value))
   ```
   We can consider making this map a global constant as it may be useful in the future.  WDYT?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org