You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@magpie.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2026/09/28 08:59:23 UTC
[PR] perf(security): skip obvious no-ops before any per-item model work [magpie]
potiuk opened a new pull request, #1449:
URL: https://github.com/apache/magpie/pull/1449
Stacked on the vetted-ops PR. Part of the **security** family optimization (#1344): the optimize-skill *pre-flight classifier* pass.
## Summary
A deterministic check now drops items the full pass would also no-op, before any body read or model classification runs. It follows the pattern of sync bulk mode's Step 1b:
- a borderline item is **kept**
- every skip is listed with its rule
- `--no-preflight` turns the check off
**security-issue-triage.** It skips a tracker when all of these hold:
- its newest comment is this skill's own triage proposal (`**Triage proposal**` / `**Proposed disposition: `)
- that comment was written by a team member
- the issue has no later update
- the reporter's mail thread has no newer message
Such trackers are waiting for the team's reaction; re-classifying them would only draft a duplicate proposal. `--retriage` and explicitly numbered trackers are never skipped. Skips show at Step 5 and Step 7 under *"Pre-flight skipped (awaiting reaction)"*. Each skip saves the per-tracker gather, the security-model and precedent steps, classification, and composition.
**security-issue-import.**
- CVE-tool bookkeeping mail is dropped in Step 1 by subject and sender, before any thread body is read. The Step 3 row stays as the backstop for the body-line variant.
- Pre-filtered threads are counted at Step 5, listed at Step 8, and can be sent back with `keep <threadId>`. `import thread:<id>` is never pre-filtered.
- A rule for GitHub tracker-mirror notifications was drafted and left out. Step 3 has no class for them, so pre-filtering them could not be shown to match what the full pass does. They stay with Step 2 and Step 2-bis, as before.
**Forwarder sub-skill.** Import, invalidate and sync load `security-issue-import-via-forwarder` (~6.4k tokens) only when both hold:
- `forwarders.enabled` is set
- a candidate matches an adapter's sender or preamble pattern
Detection is an OR of those two signals, so anything the parent skips the sub-skill would also call "not a relay". The sub-skill's own Step 1 stays the authoritative definition.
## Test plan
- [x] `prek run --all-files`; `skill-and-tool-validate`
- [x] Every eval whose extracted section changed, before (the base) and after, outside the sandbox:
| eval step | before | after |
|---|---|---|
| import step-2a / 3 / 6 / 8 | 6/6, 9/9, 3/3, 3/3 | 6/6, 9/9, 3/3, 3/3 |
| import step-5 | 2/3 | 2/3 (same pre-existing case) |
| invalidate step-5d | 2/2 | 2/2 |
| sync step-2b | 10/10 | 10/10 |
Triage evals use static prompts that this change does not reach.
Part of #1344.
Generated-by: Claude Code (Opus 5.5)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] perf(security): skip obvious no-ops before any per-item model work [magpie]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #1449:
URL: https://github.com/apache/magpie/pull/1449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org