[jira] [Commented] (SAMZA-1407) upgrade junit version to 4.12

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273657#comment-16273657 ] 

ASF GitHub Bot commented on SAMZA-1407:
---------------------------------------

GitHub user fredji97 opened a pull request:

    https://github.com/apache/samza/pull/373

    SAMZA-1407 upgrade junit version to 4.12

    "./gradlew clean check" passed 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fredji97/samza junit4_12

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/373.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #373
    
----
commit 2cb7a73e252e79f1b9e7122c35a2164206a9501f
Author: Fred Ji <ha...@gmail.com>
Date:   2017-11-30T23:29:25Z

    SAMZA-1407 upgrade junit version to 4.12

----


> upgrade junit version to 4.12 
> ------------------------------
>
>                 Key: SAMZA-1407
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1407
>             Project: Samza
>          Issue Type: Task
>            Reporter: Fred Ji
>            Assignee: Fred Ji
>             Fix For: 0.14.0
>
>
> There are some new testing code using assertNotEquals(). 
> This function is not supported in junit 4.8.1, but the explicit junit version we have in gradle file is 4.8.1. 
> Luckily, in open source build, it does not fail because powermock 1.6.6 pulls in junit 4.12 transitively. 
> In order to avoid the confusion regarding what junit version is used in test, we should explicitly upgrade junit version to 4.12. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)