You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by "Baunsgaard (via GitHub)" <gi...@apache.org> on 2023/04/21 10:00:04 UTC
[GitHub] [systemds] Baunsgaard opened a new pull request, #1807: [MINOR] Cleanup and document PCA and Scale
Baunsgaard opened a new pull request, #1807:
URL: https://github.com/apache/systemds/pull/1807
This commit adds documentation for the builtins PCA and Scale.
For Scale we add a NaN handling on internally calculated vectors, to allow the Scale builtin to work on inputs containing NaN, by essentially not scaling or shifting columns containing NaN.
PCA now include some code examples in the documentation and minor modifications such as a new argument onlyClusters that allow us to call PCA without having to apply the calculated eigenvectors to the input matrix. This modification is done because other instances i want to compare with only calculate PCA while not applying it. Also added is some minor comments inside PCA and removal of a matrix multiplication that is never used (and so far always compiled out as dead code when executing PCA)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] phaniarnab commented on pull request #1807: [MINOR] Cleanup and document PCA and Scale
Posted by "phaniarnab (via GitHub)" <gi...@apache.org>.
phaniarnab commented on PR #1807:
URL: https://github.com/apache/systemds/pull/1807#issuecomment-1518577540
> @phaniarnab I am down to 1 error. this is in the async things that you made. Can you take a look?
I reproduced and found an issue in my code. Happening due to an unhandled special case where the asynchronously collected matrix is larger than the buffer pool caching threshold.
For now, please add an `@Ignore` tag for the failing test `testPCAlm` in MaxParallelizeOrderTest. I will fix the issue in future commits.
Thanks for exposing the bug. 💯
@Baunsgaard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Baunsgaard commented on pull request #1807: [MINOR] Cleanup and document PCA and Scale
Posted by "Baunsgaard (via GitHub)" <gi...@apache.org>.
Baunsgaard commented on PR #1807:
URL: https://github.com/apache/systemds/pull/1807#issuecomment-1517994468
@phaniarnab
I am down to 1 error. this is in the async things that you made.
Can you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Baunsgaard closed pull request #1807: [MINOR] Cleanup and document PCA and Scale
Posted by "Baunsgaard (via GitHub)" <gi...@apache.org>.
Baunsgaard closed pull request #1807: [MINOR] Cleanup and document PCA and Scale
URL: https://github.com/apache/systemds/pull/1807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Baunsgaard commented on pull request #1807: [MINOR] Cleanup and document PCA and Scale
Posted by "Baunsgaard (via GitHub)" <gi...@apache.org>.
Baunsgaard commented on PR #1807:
URL: https://github.com/apache/systemds/pull/1807#issuecomment-1518637469
Great sounds good @phaniarnab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org